Skip to content

Fix Doku timestamp format to match API specification #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnindrazaka merged 1 commit into from
Sep 11, 2026
Merged

Fix Doku timestamp format to match API specification #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/data/doku/payment_repo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func ParsePrivateKeyPEM(pemStr string) (*rsa.PrivateKey, error) {
}

func formatTimestamp(t time.Time) string {
return t.Format("2006-01-02T15:04:05.000Z07:00")
return t.Format("2006-01-02T15:04:05Z07:00")
}

func formatAmount(amount float32) string {
Expand Down
10 changes: 6 additions & 4 deletions apps/api/data/doku/payment_repo_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,16 @@ func TestParsePrivateKeyPEM_NotAKey(t *testing.T) {
assert.Error(t, err)
}

func TestFormatTimestamp_ParsesBackAsRFC3339Nano(t *testing.T) {
now := time.Date(2021, 1, 8, 9, 57, 39, 877000000, time.FixedZone("WIB", 7*60*60))
func TestFormatTimestamp_MatchesDokuFormat(t *testing.T) {
now := time.Date(2020, 12, 21, 14, 56, 11, 877000000, time.FixedZone("WIB", 7*60*60))

formatted := formatTimestamp(now)

parsed, err := time.Parse(time.RFC3339Nano, formatted)
assert.Equal(t, "2020-12-21T14:56:11+07:00", formatted)

parsed, err := time.Parse(time.RFC3339, formatted)
require.NoError(t, err)
assert.True(t, now.Equal(parsed))
assert.True(t, now.Truncate(time.Second).Equal(parsed))
}

func TestFormatAmount(t *testing.T) {
Expand Down
Loading