attesting duties - #283
Open
ninaiiad wants to merge 1 commit into
Open
attesting duties#283ninaiiad wants to merge 1 commit into
ninaiiad wants to merge 1 commit into
Conversation
ninaiiad
added this pull request to stack #285
September 18, 2026 13:20
alexX512
reviewed
Sep 18, 2026
| /// block's inline `ensure_window` becomes a cache hit and every block's | ||
| /// `collect_sigs` gets the aggregate-subtract path. | ||
| pub(super) fn precompute_next_epoch_shuffling(&mut self, block_epoch: Epoch) { | ||
| pub(super) fn precompute_next_epoch_shuffling( |
Contributor
There was a problem hiding this comment.
I'm not sure that precompute is good place for passing producer as we call it also on replay during sync and there is no need to publish anything during that period. Can we move to a different place?
alexX512
reviewed
Sep 18, 2026
| let head_epoch = self.slot_state_at(self.last_applied).slot / SLOTS_PER_EPOCH; | ||
| let producer = &mut self.events_producer; | ||
| self.shuffling_cache.post_fresh(head_epoch, |epoch, shuffling| { | ||
| shuffling.post(epoch, producer, |event| producers.produce(event)) |
Contributor
There was a problem hiding this comment.
Can we have less callbacks? From my understanding we can use producer as function argument, if there will be borrow check issues you can do let Self {producer, cache, ..} = self; cache.post(epoch, producer, producers)
alexX512
reviewed
Sep 18, 2026
| /// Spec `compute_committee` over an epoch's shuffled active set: committee | ||
| /// `committee_index` of `slot` is a proportional slice, so sizes differ by at | ||
| /// most one and the committees of the epoch partition the set exactly. | ||
| pub fn committee_range( |
Contributor
There was a problem hiding this comment.
Looks like it used only in pub fn committee(&self, slot: Slot, committee_index: usize) might be we can keep it where it was before?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬