fix(e2e): pin the quick-key deck to scrollLeft 0 in the arrow-keys spec - #226
Merged
Merged
Conversation
PR #225 moved Enter and the arrow trigger to the front of the quick-key row. The arrow-keys spec still scrolled the deck to its end before taking touch coordinates, which pushed Enter off-screen on a phone-width viewport, so the raw CDP tap hit nothing and the test read back an empty line. Pin the deck at scrollLeft 0 instead. Claude-Session: https://claude.ai/code/session_01LjsynnVDDBubY6UsGnAXAq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/e2e/arrow-keys.spec.tsscrolled the quick-key deck to its end before taking raw touch coordinates, because Enter and the arrow trigger used to be the last keys. fix(mobile): unsquish the long-press numpad and reorder quick keys (v0.5.2) #225 moved them to the front, so on a phone-width viewport Enter ends up off-screen and the CDP tap hits nothing (Expected "UP", Received "(nothing)").scrollLeft = 0instead. Test-only change.Test plan
bunx playwright test tests/e2e/arrow-keys.spec.tspasses locally on the built bundlehttps://claude.ai/code/session_01LjsynnVDDBubY6UsGnAXAq