Feat stop tests button - #800
Conversation
commit: |
✅ Component tests succeed
|
✅ E2E tests succeed
|
| {title: 'Next attempt', value: '→'}, | ||
| {title: 'Run current test', value: 'r'}, | ||
| {title: 'Run all/selected tests', value: 'shift+r'}, | ||
| {title: 'Stop all tests', value: 's'}, |
There was a problem hiding this comment.
We have a conflict, like 20 lines above — S is already used for Suites page.
|
Browsers are not closed reliably on stop, I reproduced this multiple times, when after stopping, the browsers are left hanging: 
|
|
It doesn't seem to work right with multiple retries configured in UI. I tested it together with these changes: gemini-testing/testplane#1318 And yet, after clicking the stop button, it will stop only the current retry and not subsequent ones. |
|
IMO this looks pretty ugly: 
It would be really nice if we didn't show any error at all in this case, but instead clearly stated in status "Interrupted" and for example had gray icon and gray retry selector background (not red). This is not absolutely critical, but would be very nice to have. |
|
As for the button on the right: I think we should be able to stop tests from there. We should just clearly state "Stop all" if stopping individual test is currently hard to implement. I would imagine that upon clicking on "Retry" button it would be replaced with "Stop All" button, that doesn't have arrow down with options on the right and has the exact same size to avoid UI jumps |
|
I think e2e test on this is a must. Especially considering that it would be very easy to set it up: we already have GUI tests, so any LLM would easily generate this one. |
2 participants
Now user can stop all test after run using stop button which appear after click to start button.