feat: allow plugins to register additional unhandledRejection filters - #1317
Closed
Pavelgq wants to merge 1 commit into
Closed
feat: allow plugins to register additional unhandledRejection filters#1317Pavelgq wants to merge 1 commit into
Pavelgq wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done?
Context:
awaitshouldIgnoreUnhandledRejectionalready carves out an exception for known Puppeteer/CDP noise, but it's a hardcoded, closed listThis adds
registerUnhandledRejectionFilter(filter)(exposed viatestplane/unstable) so a plugin or integration can register its own predicate for cases like that, instead of it needing to get hardcoded into core the way Puppeteer's was:A filter can only ever make something get ignored, never the reverse, and a filter that throws is just treated as "no match" and logged, so a broken filter can't hide a real error. The built-in Puppeteer allowlist still takes priority. Default behavior is unchanged for everyone who doesn't use this.
How I tested?
Unit tests covering filter registration/unregistration, multiple filters, a throwing filter not breaking anything else, and the built-in Puppeteer allowlist still taking priority. Full existing suite is still green.