feat(settings): add editor font controls#2877
Open
rasitakyol wants to merge 1 commit into
Open
Conversation
4 tasks
rasitakyol
marked this pull request as ready for review
July 15, 2026 14:37
Contributor
Greptile SummaryThis PR adds persistent font controls for Monaco-backed editors. The main changes are:
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| apps/emdash-desktop/src/main/core/settings/schema.ts | Adds validation and registration for the editor typography setting. |
| apps/emdash-desktop/src/main/core/settings/settings-registry.ts | Adds the default editor font size to the settings registry. |
| apps/emdash-desktop/src/renderer/features/settings/components/FontSettingsRows.tsx | Extracts reusable font-family and font-size setting controls. |
| apps/emdash-desktop/src/renderer/features/settings/components/EditorSettingsCard.tsx | Adds independent editor font controls with normalization and size bounds. |
| apps/emdash-desktop/src/renderer/features/tasks/editor/editor-provider.tsx | Applies editor typography settings to mounted Monaco code editors. |
| apps/emdash-desktop/src/renderer/lib/monaco/sticky-diff-editor.tsx | Applies editor typography settings to mounted Monaco diff editors. |
| apps/emdash-desktop/src/renderer/lib/monaco/editor-font-settings.ts | Centralizes Monaco font option construction and default restoration. |
Reviews (1): Last reviewed commit: "feat(settings): add editor font controls" | Re-trigger Greptile
Contributor
|
@rasitakyol, thanks for opening the PR - We’ll review it soon and follow up with feedback here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add persistent font family and font size controls for Monaco-backed text previews and diffs.
editorapp setting with the current 13px behavior as its default.This is functionally independent from #2876/#2807, but the branches overlap in four small editor/settings files. I verified the combined result in a temporary integration worktree; whichever PR lands second will need a small rebase. If #2876 lands first, resetting the preference will use its updated Monaco default stack.
Related issues
Fixes #2818.
Testing
pnpm exec vitest run --project node src/main/core/settings/editor-settings.test.ts src/renderer/tests/editor-config.test.ts src/renderer/features/settings/components/font-settings-cards.test.ts src/renderer/tests/editor-font-live-update.test.ts(12/12)pnpm run lintpnpm run format:checkpnpm run typecheckpnpm run build:rendererIssueSelectorcanvas timeout under concurrent load; the failing test passed when rerun in isolation.git diff --checkScreenshot/Recording (if applicable)
Not included. The settings interactions and live Monaco updates are covered by mounted component tests.
Checklist