fix: make Wildfire result paths cross-platform - #6
Open
carlosfab wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
While reproducing the Wildfire
MANUALbaseline on macOS from upstream commitd648f128, I ran one step ofCut_Trees_Sparse_smallwith seed483and threeneutral (
0) firefighter actions. The simulation itself reachedTEST COMPLETE, produced a score of6, and made no API calls, but automaticpost-processing failed with
FileNotFoundError.The Python entrypoint had written
data.csvbelow the literal pathresults\logs\MANUAL, while Unity had written 504 frames belowresults/logs/MANUAL. A backslash is a path separator on Windows but an ordinaryfilename character on POSIX systems, so the CSV and frames ended up in different
directory trees. Rendering succeeded only after manually consolidating the
artifacts under the POSIX tree and invoking the existing renderer directly.
The same hardcoded separator pattern was present in all seven Wildfire
entrypoints and in six agent chat-log implementations.
Changes
pathlibwhilepreserving string paths at the call boundary;
algorithm templates;
paths, and co-location of result and chat artifacts.
This does not change algorithm behavior, prompts, models, dependencies, result
names, seeds, or timestamps.
Verification
python -m unittest crew_algorithms.wildfire_alg.test_paths -v— 4 tests passunder Python 3.10.11;
DeprecationWarningtreated as anerror;
git diff --checkpasses;results\logsorAgent_N\chats.txtpaths remain in the affectedruntime code.
I also repeated the original one-step smoke test against the macOS Unity build
with ML-Agents
2.3.0-exp.3/ communication protocol1.5.0. It completed withexit code
0and produced one coherent result tree containing:data.csvwith score6and zero API calls/input tokens/output tokens;backslash.
The generated CSV has the same SHA-256 as the pre-fix reference run
(
2fe85b5ffbe80cca82c076f8af3964c28ad23fdf2de164d7ca4439d9d7c67712), whilethe process now completes without the manual artifact relocation previously
needed for rendering.