Doc-sync new keyboard shortcuts + de-binary main.ts/review.ts#93
Merged
Conversation
Follow-up to the nine Impeccable surface-fix PRs (#84-#92). Docs (help.ts HELP_SECTIONS + README keyboard table): - Review: j/k line cursor + Enter/c to comment; Apply notes two-press confirm - File explorer: Cmd+E -> Cmd/Ctrl+E (Ctrl fallback added for Linux) - New Board section: arrow-key card/column nav, Enter/Space to attach, hover/focus reveals card actions (toggle_details needs no manual entry — it flows through the config-driven keybindings help block automatically.) NUL bytes: main.ts and review.ts used literal 0x00 bytes as composite-key delimiters (section\x00projectId, path\x00side), which made both files register as binary to rg/grep and silently skip in searches/CI. Replaced each literal NUL with the \x00 escape sequence — byte-identical runtime value, no collision risk, but the source is now plain text. All five sites are inside string/template literals. Also commits the nine surface critique snapshots under .impeccable/critique/. Verified: typecheck clean, 65/65 unit tests, detector clean on changed files, zero raw NUL bytes remain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the nine Impeccable surface-fix PRs (#84–#92): documents the new keyboard shortcuts those PRs added, and removes the literal NUL bytes that made two source files register as binary.
Doc-sync (help.ts
HELP_SECTIONS+ README table)j/kline cursor +Enter/cto comment the cursor line; Apply now notes the two-press confirm.Cmd+E→Cmd/Ctrl+E(Ctrl fallback added in File explorer: error state, mono-for-data, keyboard focus/roles, discoverability, Ctrl open #85 for Linux.deb/.AppImage).Enter/Spaceto attach, hover/focus reveals card actions.toggle_details(added in #89) needs no manual entry — it's aKEY_ACTIONthat flows through the config-driven "Keyboard (claude-commander config)" help block automatically viaapplyHelpKeybindings().NUL-byte cleanup
src/main.ts(2) andsrc/review.ts(3) used literal0x00bytes as composite-key delimiters (sect:${section}\x00${projectId},${path}\x00${side}). A raw NUL makes the whole file register as binary torg/grep, so they were silently skipped in searches and CI greps — and this misled two critique assessors during the review phase.Fix: replaced each literal NUL with the
\\x00escape sequence. Runtime value is byte-identical (still a NUL delimiter → no collision risk, no behavior change), but the source is now plain ASCII text. All five sites are inside string/template literals where\\x00is a valid escape.Also
Commits the nine surface critique snapshots under
.impeccable/critique/(matching the main-shell precedent from #83).Verification
npm run typecheck— cleannpm test— 65/65detect.mjs— clean onmain.ts,review.ts,help.tsrgnow reads both files normally)🤖 Generated with Claude Code