fix(js/core): allow Gemini propertyOrdering in schema validation - #5865
Open
a2105z wants to merge 1 commit into
Open
fix(js/core): allow Gemini propertyOrdering in schema validation#5865a2105z wants to merge 1 commit into
a2105z wants to merge 1 commit into
Conversation
Register the non-standard propertyOrdering keyword with Ajv so structured output schemas that include Gemini field-order hints no longer fail to compile.
Contributor
There was a problem hiding this comment.
Code Review
This pull request registers the non-standard propertyOrdering keyword in Ajv to prevent strict mode validation errors when processing Gemini structured output schemas. It also adds corresponding unit tests to verify that schemas containing propertyOrdering are correctly validated in both standard and interpret modes. I have no feedback to provide.
Author
|
Hi @pavelgj @ssbushi — whenever you have a moment, could you take a look at this small It registers Gemini's non-standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
propertyOrderingJSON Schema keyword with Ajv so structured-output schemas that include it no longer fail withstrict mode: unknown keyword.propertyOrderingis present.Fixes #3764
Test plan
npm testinjs/core(179 tests passing)ai.generate+output.jsonSchema.propertyOrderingcase and confirm it no longer throws