Skip to content

chore: sort out pending fixes and build/CI plumbing #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kp2pml30 wants to merge 2 commits into
base: v0.2-dev
Choose a base branch
from
Open

chore: sort out pending fixes and build/CI plumbing #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
711d902
chore(third-party): adopt content-addressed patch names 🚚
kp2pml30 Sep 7, 2026
bac7bb2
chore(supervisor): drop the dead saturating-float toggle 🔥
kp2pml30 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .git-third-party/.gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Managed by git-third-party.

# Patch names are a digest of the patch bytes: normalizing them changes what
# gets applied, and breaks the name.
patches/** -text
manifest.json text eol=lf
5 changes: 5 additions & 0 deletions .git-third-party/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Managed by git-third-party.

# Scratch left behind by an interrupted write.
*.tmp
patches/**/*.tmp
9 changes: 7 additions & 2 deletions .git-third-party/config.json → .git-third-party/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,18 @@
"executor/third-party/wasmtime": {
"url": "https://github.com/bytecodealliance/wasmtime.git",
"commit": "6844a83b530f86ad13a65175282fe2dbcd33cad1",
"patches": 2,
"patches": [
"41ma00mnkw1fck5s",
"1rntcejzarfn1yww"
],
"submodules": []
},
"executor/third-party/wasm-tools": {
"url": "https://github.com/bytecodealliance/wasm-tools.git",
"commit": "76927bf4bdbddf4b15f835c5eddfffbdfe3bdbd5",
"patches": 1
"patches": [
"gk2m1xpfybm4kec2"
]
}
}
}
0 ...patches/executor/third-party/wasm-tools/1 → ...r/third-party/wasm-tools/gk2m1xpfybm4kec2
View file
Open in desktop
File renamed without changes.
0 ...y/patches/executor/third-party/wasmtime/2 → ...tor/third-party/wasmtime/1rntcejzarfn1yww
View file
Open in desktop
File renamed without changes.
0 ...y/patches/executor/third-party/wasmtime/1 → ...tor/third-party/wasmtime/41ma00mnkw1fck5s
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion executor/src/rt/errors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ impl UnwrapDynError {
/// independent of the wasm store and can be done even after it is consumed.
pub fn extract_backtrace(err: &UnwrapDynError) -> Option<Backtrace> {
let Some(bt) = err.downcast_ref::<wasmtime::WasmBacktrace>() else {
log_warn!("no backtrace attached");
log_debug!("no backtrace attached");
return None;
};

Expand Down
1 change: 0 additions & 1 deletion executor/src/rt/supervisor/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ pub fn create_engines(
.wasm_features(WasmFeatures::SIGN_EXTENSION, true)
.wasm_features(WasmFeatures::MUTABLE_GLOBAL, true)
.wasm_features(WasmFeatures::MULTI_VALUE, true)
.wasm_features(WasmFeatures::SATURATING_FLOAT_TO_INT, false)
//.wasm_features(WasmFeatures::REFERENCE_TYPES, false)
.wasm_features(WasmFeatures::SATURATING_FLOAT_TO_INT, true);

Expand Down