Skip to content

chore: sort out pending fixes and build/CI plumbing - #36

Open
kp2pml30 wants to merge 4 commits into
v0.3-devfrom
pr/v0.3/chore/sort-out-prs
Open

chore: sort out pending fixes and build/CI plumbing#36
kp2pml30 wants to merge 4 commits into
v0.3-devfrom
pr/v0.3/chore/sort-out-prs

Conversation

@kp2pml30

@kp2pml30 kp2pml30 commented Sep 8, 2026

Copy link
Copy Markdown
Member

Auto-opened executor mirror of genlayerlabs/genvm-manager#34.

Carries the executor-side work for that manager PR. The manager branch update fast-forwards v0.3-dev to its pinned commit after landing.

kp2pml30 and others added 4 commits September 7, 2026 17:46
The range check added index and length in u32, so an access naming the last
octet always overflowed and was refused: every slot was one octet shorter
than the 2**32 the specification states.

Co-authored-by: Edgars Nemše <edgars@genlayerlabs.com>
Patch files were named by their position, so inserting one rewrote every
name after it. They now carry a digest of their own bytes and the manifest
holds the order; `config.json` becomes `manifest.json`, which is what that
file has always been.
Wasmtime 48 is an LTS release, so it stays supported for 24 months rather
than 2. wasm-tools moves to v1.254.0 in lockstep because wasmtime pins
wasmparser 0.254, and the vendored crates must resolve to one version.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2debdcaa-3f5f-4f64-bbe0-1c774e0099df

📥 Commits

Reviewing files that changed from the base of the PR and between ee7b551 and a004192.

⛔ Files ignored due to path filters (15)
  • .git-third-party/config.json is excluded by !**/*.json
  • .git-third-party/manifest.json is excluded by !**/*.json
  • executor/Cargo.lock is excluded by !**/*.lock, !**/*.lock
  • tests/integration/exploit/storage_rw_long/storage_r_long.py is excluded by !**/tests/**
  • tests/integration/exploit/storage_rw_long/storage_rw_long.0.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/exploit/storage_rw_long/storage_rw_long.0_0.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/exploit/storage_rw_long/storage_rw_long.jsonnet is excluded by !**/tests/**
  • tests/integration/exploit/storage_rw_long/storage_w_long.py is excluded by !**/tests/**
  • tests/integration/exploit/storage_slot_edge/storage_slot_edge.jsonnet is excluded by !**/tests/**
  • tests/integration/exploit/storage_slot_edge/storage_slot_edge.py is excluded by !**/tests/**
  • tests/integration/exploit/storage_slot_edge/storage_slot_edge.read_ends_at_end.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/exploit/storage_slot_edge/storage_slot_edge.read_last_byte.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/exploit/storage_slot_edge/storage_slot_edge.read_over_end.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/exploit/storage_slot_edge/storage_slot_edge.write_last_byte.stdout is excluded by !**/*.stdout, !**/tests/**
  • tests/integration/exploit/storage_slot_edge/storage_slot_edge.write_over_end.stdout is excluded by !**/*.stdout, !**/tests/**
📒 Files selected for processing (17)
  • .git-third-party/.gitattributes
  • .git-third-party/.gitignore
  • .git-third-party/patches/executor/third-party/wasm-tools/n359mz2sdabr2wsa
  • .git-third-party/patches/executor/third-party/wasmtime/4
  • .git-third-party/patches/executor/third-party/wasmtime/4rr93pqjtwm5m701
  • .git-third-party/patches/executor/third-party/wasmtime/5
  • .git-third-party/patches/executor/third-party/wasmtime/6xy06vg0d71czwmm
  • .git-third-party/patches/executor/third-party/wasmtime/gbm0xv16dc1fs2km
  • .git-third-party/patches/executor/third-party/wasmtime/r6518c8dxghpkhsj
  • .git-third-party/patches/executor/third-party/wasmtime/zsjxmza3dms0hr10
  • executor/crates/common/src/expr/evaluator.rs
  • executor/crates/common/src/expr/value.rs
  • executor/src/rt/errors.rs
  • executor/src/rt/supervisor/mod.rs
  • executor/src/rt/vm/storage.rs
  • executor/src/wasi/genlayer_sdk/mod.rs
  • executor/src/wasi/genlayer_sdk/tests.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant