chore: sort out pending fixes and build/CI plumbing - #36
Open
kp2pml30 wants to merge 4 commits into
Open
Conversation
The range check added index and length in u32, so an access naming the last octet always overflowed and was refused: every slot was one octet shorter than the 2**32 the specification states. Co-authored-by: Edgars Nemše <edgars@genlayerlabs.com>
Patch files were named by their position, so inserting one rewrote every name after it. They now carry a digest of their own bytes and the manifest holds the order; `config.json` becomes `manifest.json`, which is what that file has always been.
Wasmtime 48 is an LTS release, so it stays supported for 24 months rather than 2. wasm-tools moves to v1.254.0 in lockstep because wasmtime pins wasmparser 0.254, and the vendored crates must resolve to one version.
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (15)
📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened executor mirror of genlayerlabs/genvm-manager#34.
Carries the executor-side work for that manager PR. The manager branch update fast-forwards
v0.3-devto its pinned commit after landing.