feat(app-create): seed placement size from the slot's registry default [BEX-461] - #91
Closed
piyushsarin-sib wants to merge 1 commit into
Closed
Conversation
…t [BEX-461] The registry default card size (extension_points metadata.default_size, served as default_size on GET /cli/surface-points) becomes a CREATE-TIME seed, the same mechanism as context/default_context_field: written explicitly into the entry's size, where the partner can see and edit it. The entry's own value is what upload validates and the platform serves — no manifest change, no kit fallback, no cacheSchemaVersion bump. - SurfacePointRow gains default_size (typed, nullable). - buildSurfacePointList takes sizeFor (per-row, like contextFor); sanitizeSeededSize degrades a blank/malformed served default to no seed rather than authoring a value validateUiApp then refuses. - No size prompt, unchanged (D2). - Tests: seeded from the picked row, absent when the row declares none, malformed default dropped. Docs (SKILL.md/AGENTS.md) + changeset. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: BEX-461 · Epic: BEX-211
What
The registry's per-slot default card size becomes a create-time seed, the same mechanism
contextalready uses:brevo app createreadsdefault_sizeoff the picked registry row (GET /v3/app-store/surface-points, published by app-store-bo-be#405) and writes it into the authored entry'ssize— explicit inapp-config.json, editable, and the entry's own value is what upload validates and the platform serves. No manifest change, no kit fallback read, nocacheSchemaVersionbump — that render-time alternative stays the follow-up only if product ever needs to restyle existing sizeless apps platform-wide.SurfacePointRow.default_size(typed, nullable) — flows through the existing row normalization untouched.buildSurfacePointListgainssizeFor(per-row, exactly likecontextFor); a slot with no default writes nosizekey, so behavior is unchanged wherever the registry declares nothing.sanitizeSeededSize: a server predating the field, or echoing a blank/malformed shape, degrades to "no seed" rather than authoring a valuevalidateUiApprefuses in the very flow that wrote it.SKILL.md/AGENTS.md) +minorchangeset. 1418 tests green.One knob, two surfaces — worth knowing
Per-entry
sizedrives the widget card box and the modal body height. A seededheight: 200pxon aniframeExtensionwidget entry therefore also makes its modal 200px tall — visible in the file, trivially edited, but if product prefers modals to keep the 72vh default, the one-line change is to skip seeding on the iframe branch. Flagging rather than deciding.Stacked
Base is
feat/iframe-extension-authoring(PR #87) — both touchbuildSurfacePointList. Merge #87 first; this then retargets tomainautomatically.🤖 Generated with Claude Code