Conversation
A reply to a status on a different server threw “Not a reply to a URL at this target” and failed the syndication. Resolve the status through the search API, which fetches it over ActivityPub if needed, and thread the reply to the returned ID. A URL that can’t be resolved is posted as an unthreaded status instead of being dropped. Fixes #926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #926.
createStatusno longer throws for anin-reply-toon another server; it still setsinReplyToIdfor same-server replies.Mastodon#resolveRemoteStatussearches/api/v2/search?type=statuses&resolve=true, andpost()threads the reply to the resolved ID. An unresolvable URL posts an unthreaded status.in_reply_to_id, so the tests prove threading rather than only that a status was posted.createStatusfor an off-server reply no longer throws.Verified locally:
node --test packages/syndicator-mastodon/test/unit/*.js40/40, eslint and prettier clean.