ci: Separate static analysis from Pana - #3914
Draft
buenaflor wants to merge 2 commits into
Draft
Conversation
Use the tool name for the path-filtered package scoring workflow so it is clearly distinct from the always-on static analysis workflow. Co-Authored-By: Codex <noreply@openai.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Features
FixesFlutter
Other
DependenciesDeps
Internal Changes
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3914 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 338 338
Lines 12345 12345
=======================================
Hits 10810 10810
Misses 1535 1535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Keep the always-on analysis matrix and its package steps in one workflow. Remove the single-consumer reusable worker while leaving Pana scoring reusable for package-specific workflows. Co-Authored-By: Codex <noreply@openai.com>
buenaflor
changed the title
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Comment on lines
11
to
12
| - '.github/actions/flutter-test/**' | ||
| - '.github/actions/coverage/**' |
There was a problem hiding this comment.
sqflite workflow self-reference path trigger incorrectly changed to logging.yml
The sqflite.yml workflow's pull_request.paths trigger references .github/workflows/logging.yml instead of .github/workflows/sqflite.yml, so changes to sqflite.yml itself will not trigger the workflow.
Evidence
- The
sqflite.ymlpull_request.pathslist on line 9 shows.github/workflows/logging.ymlinstead of the expected.github/workflows/sqflite.yml. - Every other package workflow (dart, dio, drift, file, firebase_remote_config, grpc, hive, isar, link, logging, supabase, flutter) correctly references its own workflow file in its path triggers.
- The issue was introduced during the mass rename from
package-analysis.ymltopana.yml, likely via a regex/sed that incorrectly matched theloggingpackage pattern in thesqflitefile.
Identified by Warden review · WYK-LJW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
analyze.ymlnow owns the always-on package matrix and static-analysis steps directly, removing the single-useanalyze-package.ymlreusable workflow. The path-filtered scoring workflow is renamed topana.yml, with package callers using matchingpanajobs.This keeps the existing required check unchanged while making each workflow responsibility explicit: static analysis always runs, while Pana remains reusable and path-scoped.