chore(deps): update CLI to v3.5.1 - #259
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
github-actions
Bot
force-pushed
the
deps/sentry-cli.properties/3.5.1
branch
from
June 17, 2026 04:35
50eac5f to
6340dc3
Compare
| @@ -1,2 +1,2 @@ | |||
| version = 3.3.0 | |||
| version = 3.5.1 | |||
| repo = https://github.com/getsentry/sentry-cli | |||
There was a problem hiding this comment.
Bug: The download-sentry-cli.sh script lacks error handling for curl downloads. If a binary is missing for a platform, an invalid file is created, causing later build failures.
Severity: MEDIUM
Suggested Fix
Add the -f or --fail flag to the curl commands in download-sentry-cli.sh. This will cause curl to exit with a non-zero status code on HTTP errors (like 404 Not Found), which will then fail the build script as intended by failonerror="true" in the pom.xml.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: sentry-cli.properties#L2
Potential issue: The `download-sentry-cli.sh` script uses `curl -SL` without the `-f`
flag to download `sentry-cli` binaries. If a binary for a specific platform (e.g.,
32-bit Windows or Linux) is not available for the new version 3.5.1, `curl` will still
exit successfully, creating an empty or invalid file. The build process does not
validate the downloaded files. This will lead to build failures on those platforms when
they attempt to execute the corrupted binary. Since CI only tests 64-bit platforms, this
issue would not be caught before merging.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps sentry-cli.properties from 3.3.0 to 3.5.1.
Auto-generated by a dependency updater.
Changelog
3.5.1
Internal Changes 🔧
Deps
Other
3.5.0
Features
snapshots diffcommand for locally comparing directories of PNG snapshot images using odiff (#3306)snapshots downloadcommand for downloading baseline snapshot images from Sentry (#3310)--all-image-file-namesand--all-image-file-names-fileflags tosnapshots uploadfor detecting image removals and renames in selective builds (#3312)Fixes
CURL_CA_BUNDLEandSSL_CERT_FILEwhen configuring TLS certificate authorities (#3301).Internal changes
symbolicto13.1.1(#3240)3.4.3
Security Fixes
Info.plistpreprocessing by default to avoid passing project-controlled compiler settings toccduring release auto-discovery. This affectssentry-cli releases propose-version,sentry-cli send-eventandsentry-cli bash-hook --send-eventrelease inference, andsentry-cli react-native xcodeauto-release detection. Use--allow-xcode-infoplist-preprocessingonly for trusted projects that require preprocessing.sentry-cli loginupdates existing config files.http.verify_sslis set tofalse, case-insensitively.bash-hookarguments, including paths, tags, release names, and the CLI path.sentry-cli bash-hookevents.sentry-cli update.Performance
Fixes
3.4.2
Fixes
serializeOptions. String/number options now validate input types and preventArray.prototype.concat()from flattening array values into separate CLI arguments. (#3287)3.4.1
Improvements
--excludeto scope the bundle to a single variant (#3275).Fixes
[<module>/]src/<sourceset>/<lang>/prefix from bundle URLs so Symbolicator can resolve them from package-based stack traces (e.g.sentry-android-core/src/main/java/io/sentry/android/core/ANRWatchDog.java→~/io/sentry/android/core/ANRWatchDog.jvm) (#3275).3.4.0
Features
--selectiveflag tobuild snapshotsto indicate the upload contains only a subset of images (#3268).java,.kt,.scala,.groovy), respecting.gitignore, and excluding common build output directories (#3260)--excludeoption for custom glob patterns to exclude files/directories from source collection (#3260)Performance
Fixes
eprintln!withlog::info!for progress bar completion messages when the progress bar is disabled (e.g. in CI). This avoids spurious stderr output that some CI systems treat as errors (#3223).3.3.5
Performance
Fixes
3.3.4
New Features ✨
--diff-thresholdoption tobuild snapshotsto set a minimum pixel difference percentage for reporting image changes (#3259)sentry-cli build downloadcommand to download installable builds (IPA/APK) by build ID (#3221).sentry-cli code-mappings uploadcommand to bulk upload code mappings from a JSON file (#3207, #3208, #3209, #3210).com/example/module) to source paths in your repository (e.g.src/main/java/com/example/module), enabling Sentry to display source context and link directly to your code from error stack traces.--repoand--default-branch.3.3.3
Internal Changes 🔧
3.3.2
New Features ✨
Internal Changes 🔧
3.3.1
Fixes
.xcarchiveor.ipafiles on non-Apple Silicon Macs (#3211).Experimental Feature 🧑🔬 (internal-only)
sentry-cli build snapshotscommand (#3163).