feat(ui): display Sentry User Feedback events - #1346
Merged
Conversation
Feedback envelope items (type "feedback", sent by the SDK's feedbackIntegration) were delivered to the sidecar but never rendered: "feedback" was not in SUPPORTED_EVENT_TYPES, so pushEnvelope dropped them, and there was no panel to show them. - recognize "feedback" as a supported event type so it reaches the store - add SentryFeedbackEvent type + isFeedbackEvent guard - add a Feedback tab (list + detail) with sidebar link and count - link feedback back to its associated error/trace when present Fixes #1343
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 1211 uncovered lines. Generated by Codecov Action |
BYK
approved these changes
Aug 7, 2026
BYK
marked this pull request as ready for review
August 7, 2026 14:40
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the "User Feedback events received but not displayed" part of #1343.
Problem
Sentry User Feedback (envelope item type
feedback, sent by the browser SDK'sfeedbackIntegration) reaches the sidecar/streamfine, but the overlay never renders it. Two gaps:feedbackwas not inSUPPORTED_EVENT_TYPES, soenvelopesSlice.pushEnvelopesilently dropped these items and never calledpushEvent.exception.Change
FEEDBACK_EVENT_TYPESand include it inSUPPORTED_EVENT_TYPESso feedback items flow into the store like any other event.FeedbackContext,SentryFeedbackEvent(in theSentryEventunion), and anisFeedbackEventguard.isErrorEventalready requires anexception, so feedback stays out of the Errors tab.FeedbackList+FeedbackDetails), a route inTelemetryView, and a sidebar link with a live count. Detail view shows message, name, email, url, source, and links back to the associated error/trace when present.feedback.spec.tsasserts afeedbackenvelope item is ingested viapushEnvelopeand retrievable as a feedback event.Not included
The issue's first item (sidecar crash
ctx.req.query().toString) is already fixed onmainin commit5bbaa0f, which changed the self-instrumentation span tonew URL(ctx.req.url).searchParams.toString(). The reporter is on released4.11.8, which predates that fix. No code change needed there.Testing
vitest run— new feedback test passes; all previously-passing UI/store tests still pass. (21 failures inserver/utils/__tests__/docker-compose.test.tsare pre-existing onmainand unrelated.)tsc --noEmit— zero new type errors in the touched files (the repo has ~110 pre-existing errors onmain).biome check— clean on all touched files.Implementation plan
constants/sentry.ts:FEEDBACK_EVENT_TYPES+ add toSUPPORTED_EVENT_TYPES.types.ts:FeedbackContext,Contexts.feedback,SentryFeedbackEvent, union update.utils/sentry.ts:isFeedbackEvent.components/feedback/FeedbackList.tsx,components/feedback/FeedbackDetails.tsx,tabs/FeedbackTab.tsx.components/TelemetryView.tsx: route +feedbackCount.components/TelemetrySidebar.tsx: nav link + prop.store/slices/feedback.spec.ts: ingestion test.