SVE 128 bit Implementation of gemm_q4_k_8x8_q8_k kernel - #27491
Open
anubhavfujitsu wants to merge 19 commits into
Open
SVE 128 bit Implementation of gemm_q4_k_8x8_q8_k kernel#27491anubhavfujitsu wants to merge 19 commits into
anubhavfujitsu wants to merge 19 commits into
Conversation
…xist due to bsums array
|
Hi @anubhavfujitsu, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds 128-bit SVE (Scalable Vector Extensions) support for the ggml_gemm_q4_K_8x8_q8_K kernel using i8mm and vector instructions.
Additional information
By running a Q4_K_M quantized model of Llama-3.2-3B-Instruct, I have checked the generation output.
I also verified that the perplexity matches between the NEON and SVE implementations.
The command used to measure the perplexity is:
./llama-perplexity -m model.gguf -f wikitext-2-raw/wiki.test.raw --chunks 10Performance Check
This PR Improves the Prompt Eval time (TTFT) of LLM Inference between ~4 to 5%, as compared to NEON (Original Version) for Llama-3.2-3B-Instruct-Q4_K_M.
The performance was measured on Nvidia Grace machine.
Performance is improved as follows. The value is tokens/second.
Requirements