webgpu : reorder fattn includes to fix unresolved V error - #27545
Open
fairydreaming wants to merge 1 commit into
Open
webgpu : reorder fattn includes to fix unresolved V error#27545fairydreaming wants to merge 1 commit into
fairydreaming wants to merge 1 commit into
Conversation
…ay be defined as K in flash_attn_decls.tmpl if KV_OVERLAP
github-actions
Bot
added
ggml
CISC
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
If
KV_OVERLAPis definedflash_attn_decls.tmpldefinesVasK, but after #25956 first occurrence ofVis now incommon_decls.tmplthat is included earlier. This causesError while parsing WGSL: :40:16 error: unresolved value 'V'errors - probably in recently added V-is-view-of-K FA tests from #27394. This PR reorders these includes to ensure V macro is defined before first V occurrence.Requirements