Conversation
asgerf
force-pushed
the
unified/call-graph-static
branch
4 times, most recently
from
September 18, 2026 12:02
e9da755 to
a916e8b
Compare
asgerf
force-pushed
the
unified/call-graph-static
branch
from
September 19, 2026 08:11
0f11ca1 to
032b47b
Compare
A parameter with only one name has that name as its internal and external parameter name.
The previous commit resulted in data-flow consistency errors due to having local flow into a post-update node (for good reason). We now skip over the synthetic read node in use-use flow, so the use-use flow is not seen as a mutation of a variable.
This changes the type from Expr -> AstNode and renames the column. This should just be an arbitrary representative for the access; it does not have to be an Expr.
Note that some of them are failing because 'self.store()' is not resolved by static name binding.
This should be taken from the CFG node instead of the AST node
This fixes a data flow consistency error due to ArgumentNodes for constructor patterns missing their PostUpdateNode.
asgerf
force-pushed
the
unified/call-graph-static
branch
from
September 19, 2026 08:20
032b47b to
832dfb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables flow through calls, using a basic call graph derived from static name resolution.
Most of the work is wiring up argument/parameter positions and post-update nodes correctly.