Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused guard filtering matches the intended behavior and is covered by an appropriate regression test.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes duplicate go/index-out-of-bounds alerts by reporting only the innermost dominating guard.
Changes:
- Filters out enclosing duplicate guards.
- Adds a regression test for chained conditions.
- Updates expected query results.
| File | Description |
|---|---|
go/ql/src/InconsistentCode/LengthComparisonOffByOne.ql |
Selects the innermost applicable guard. |
go/ql/test/query-tests/InconsistentCode/LengthComparisonOffByOne/main.go |
Adds the regression case. |
go/ql/test/query-tests/InconsistentCode/LengthComparisonOffByOne/LengthComparisonOffByOne.expected |
Records the single expected alert. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the result should be
Aand it is in a condition likeA && B && Cthen we were creating results forAandA && BandA && B && C. This was caused by changes to guards in #22182. The fix is to only alert for the innermost condition. A test has been added to demonstrate the bug and show that it is fixed.This does not need a change note as it is fixing FPs that haven't been in any release.