Skip to content

Add regression test: blob content readable next to a submodule #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lyrixx merged 1 commit into from
Sep 7, 2026
Merged

Add regression test: blob content readable next to a submodule #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/Gitonomy/Git/Tests/BlobTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,21 @@ public function testGetContent(Repository $repository): void
$this->assertStringContainsString(self::README_FRAGMENT, $blob->getContent());
}

#[DataProvider('provideFoobar')]
public function testGetContentSiblingToSubmodule(Repository $repository): void
{
// Regression test for https://github.com/gitonomy/gitlib/issues/12:
// a submodule entry in a tree used to break parsing of that tree,
// making sibling blobs unreadable.
$tree = $repository->getCommit(self::NO_MESSAGE_COMMIT)->getTree();

$this->assertNotEmpty($tree->getCommitReferenceEntries(), 'Tree contains a submodule entry');

$blob = $tree->resolvePath('README.md');

$this->assertStringContainsString(self::README_FRAGMENT, $blob->getContent());
}

#[DataProvider('provideFoobar')]
public function testNotExisting(Repository $repository): void
{
Expand Down