Integrate custom campaign calendar, fix font persistence and resize bugs - #1
Open
elthairselanim wants to merge 4 commits into
Open
Integrate custom campaign calendar, fix font persistence and resize bugs#1elthairselanim wants to merge 4 commits into
elthairselanim wants to merge 4 commits into
Conversation
Adapts the timeline to read dates from Foundry's core game.time.calendar (as configured by wgtgm-mini-calendar) instead of assuming the real Gregorian calendar: calendar-aware date storage/picker/display, plus a date format toggle (Month Day, Year vs Day Month, Year). Also fixes several pre-existing bugs: fonts not persisting when reopening an event for edit (broken string parsing), the timeline canvas never resizing after first render (missing width option), and a dangling Promise when cancelling the event dialog. Fonts now come from Foundry's own Configure Fonts registry instead of a hardcoded list plus an external Google Fonts CDN call. Adds a Delete button for single events, switches "Clear Timeline" to Foundry's own DialogV2.confirm, and trims stale comments/debug console.log noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapts the timeline to read dates from Foundry's core game.time.calendar (as configured by wgtgm-mini-calendar) instead of assuming the real Gregorian calendar: calendar-aware date storage/picker/display, plus a date format toggle (Month Day, Year vs Day Month, Year).
Also fixes several pre-existing bugs: fonts not persisting when reopening an event for edit (broken string parsing), the timeline canvas never resizing after first render (missing width option), and a dangling Promise when cancelling the event dialog. Fonts now come from Foundry's own Configure Fonts registry instead of a hardcoded list plus an external Google Fonts CDN call. Adds a Delete button for single events, switches "Clear Timeline" to Foundry's own DialogV2.confirm, and trims stale comments/debug console.log noise.