refactor(ui): source the Go fonts from go-opentype, not golang.org/x/image - #97
Merged
Conversation
…image Deleting the private x/image rasteriser left the reader importing golang.org/x/image for exactly two things: the Go Regular and Go Bold byte blobs. Font data, not code — and go-opentype/fonts is where this ecosystem keeps font data. go-opentype/fonts v0.7.0 now bundles the family's designed weights, so ui/text.go takes goregular.TTF and goregular.BoldTTF from there. The reader's own code no longer imports golang.org/x/image ANYWHERE, tests included. It stays in the module graph as an indirect dependency, because go-iconoir/iconoir needs x/image/vector to rasterise its SVG paths — that is iconoir's call, not something this repo can drop. Rendering is unchanged, and provably so rather than plausibly: the bundled Go-Regular is byte-identical to x/image's (sha256 197d9f37…, 148672 bytes) and Go Bold comes from the same upstream release, so all 45 rendered snapshots are BYTE-IDENTICAL before and after — 0 differing pixels, not 0.00% rounded. 100% coverage held; race-clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Deleting the private x/image rasteriser (#96) left the reader importing
golang.org/x/imagefor exactly two things: the Go Regular and Go Bold byte blobs. Font data, not code — andgo-opentype/fontsis where this ecosystem keeps font data.What
go-opentype/fonts v0.7.0 now bundles the family's designed weights, so
ui/text.gotakesgoregular.TTFandgoregular.BoldTTFfrom there.The reader's own code no longer imports
golang.org/x/imageanywhere, tests included. It stays in the module graph as an indirect dependency, becausego-iconoir/iconoirneedsx/image/vectorto rasterise its SVG paths — that is iconoir's call, not something this repo can drop.Rendering is unchanged, provably
The bundled
Go-Regularis byte-identical to x/image's (sha256197d9f37…, 148672 bytes) and Go Bold comes from the same upstream release, so this is a pure sourcing change.All 45 rendered snapshots are byte-identical before and after —
cmpreports 0 differing files, not "0.00% rounded".Verification
go test -raceover the gated packages → 100.0% of statements, race-clean.🤖 Generated with Claude Code