Do not embed reflect.Value into exportedMethod - #436
Merged
Merged
Conversation
kolyshkin
force-pushed
the
no-embed-reflect-value
branch
from
September 22, 2026 19:42
20cf11a to
796b365
Compare
Contributor
Author
|
(an initial version of this PR claimed this is needed to re-enable DCE -- this was wrong). |
Embedding reflect.Value promotes all of its methods to exportedMethod, and since it is used via an interface, the linker has to keep them. None of these are needed; use a named field instead. This makes the test binary about 74K smaller. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
guelfey
force-pushed
the
no-embed-reflect-value
branch
from
September 24, 2026 12:44
796b365 to
3b9769b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedding
reflect.Valuepromotes all of its methods toexportedMethod, which the linker then has to keep since the type is used via an interface. None of them are needed; use a named field instead.A minor cleanup; makes the test binary about 74K smaller.