feat!: Key enum redesign — grouped bases, 138 keys, KeyFromString - #26
Merged
Conversation
…tring BREAKING: Key numeric values changed (grouped bases replace flat iota). Pre-v1.0 — no external consumers store numeric values. - 12 grouped const blocks with reserved gaps (net/http pattern) - 44 new keys: F13-F24, Media, Volume, Browser, System, Intl - KeyFromString() thread-safe reverse lookup (sync.Once) - String() for all 138 keys - W3C UIEvents naming convention
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
constblocks with reserved gaps (net/httppattern)KeyFromString()thread-safe reverse lookup (sync.Once)BREAKING
Key numeric values changed. Pre-v1.0 — no external consumers store numeric values. This is the last chance to renumber before v1.0 stability commitment.
Enterprise references
net/http: explicit grouped values (100, 200, 300...)Test plan
go test ./...— 87 tests passgolangci-lint run— 0 issues