Skip to content

feat: add event stringers - #27

Open
besmpl wants to merge 1 commit into
gogpu:mainfrom
besmpl:agent/add-event-stringers
Open

feat: add event stringers#27
besmpl wants to merge 1 commit into
gogpu:mainfrom
besmpl:agent/add-event-stringers

Conversation

@besmpl

@besmpl besmpl commented Aug 10, 2026

Copy link
Copy Markdown

Summary

  • add MouseButton.String names consistent with the newer pointer Button type
  • add deterministic Modifiers.String output in the same order used by gogpu/ui
  • share existing directional string constants so the package remains lint-clean
  • cover every button, individual and combined modifiers, locks, zero, and unknown bits

Why

The public event enums should be directly useful in logs and diagnostics. Key already implements fmt.Stringer; this completes the remaining event Stringer slice from the API audit without changing type layout or event behavior.

Verification

  • go test ./...
  • go test -race ./...
  • go build ./...
  • go vet ./...
  • golangci-lint run --timeout=5m
  • go test -covermode=atomic -coverprofile=coverage.out ./... — 90.0% total statement coverage and 100% of changed production statements (28/28; no uncovered changed blocks)
  • gofmt and git diff --check

CI note: GitHub marks this fork pull request's workflow run as action_required; upstream Actions and the Codecov upload will start after a repository maintainer approves the run.

Addresses the MouseButton/Modifiers Stringer item in #19; the broader API audit remains open.

@besmpl
besmpl requested a review from kolkov as a code owner August 10, 2026 17:11
@besmpl
besmpl force-pushed the agent/add-event-stringers branch from 0e5ee5d to 8952bc5 Compare August 10, 2026 20:14
@besmpl
besmpl force-pushed the agent/add-event-stringers branch from 8952bc5 to 387bb88 Compare August 10, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant