Skip to content

WEB-4512 Rebranding fixes #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
czechian merged 1 commit into from
Jul 23, 2026
Merged

WEB-4512 Rebranding fixes #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions assets/scss/_styles_project.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@
@media only screen and (min-width: 993px) {
.gd-footer-banner-links .gd-footer-banner-links-item {
padding: 80px 40px;
margin: 0;
max-width: none;
}
}

Expand All @@ -76,10 +74,5 @@
margin: 32px 0 24px;
line-height: 24px;
}

.gd-footer-buttons {
justify-content: flex-start;
padding: 0;
}
}
}
2 changes: 1 addition & 1 deletion assets/scss/dark-theme/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
.form-control,
.td-search-input {
color: $color-white !important;
background: $color-marlin-black !important;
background-color: $color-marlin-black !important;
border-color: transparent !important;
box-shadow: none !important;

Expand Down
4 changes: 4 additions & 0 deletions assets/scss/dark-theme/menu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@
background: $color-black;
color: $color-mist-gray;

&__mobile-icon::before {
filter: brightness(0) invert(1);
}

&-section + &-section {
border-top-color: $color-gunpowder-gray;
}
Expand Down
9 changes: 9 additions & 0 deletions assets/scss/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@

&__left {
display: flex;
height: 100%;
}
Comment on lines 109 to 112

@coderabbitai coderabbitai Bot Jul 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

git ls-files assets/scss/header.scss
echo '---'
cat -n assets/scss/header.scss | sed -n '1,220p'

Repository: gooddata/gooddata-docs-theme

Length of output: 5936

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n "gd-docs-header-nav__first|header-first-nav-height|height: 100%;" assets/scss assets -g '*.scss' -g '*.css'

Repository: gooddata/gooddata-docs-theme

Length of output: 3536

Give .gd-docs-header-nav__first a definite height before relying on height: 100% here.
min-height doesn’t give &__left / &__logo a reliable percentage-height reference, so the logo can still fall back to auto in this layout. Set an explicit header-row height or switch this to stretch-based sizing.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@assets/scss/header.scss` around lines 109 - 112, Update the header sizing
around `&__left` so its `height: 100%` has a definite
`.gd-docs-header-nav__first` height reference, either by assigning an explicit
header-row height or using stretch-based sizing; ensure the nested `&__logo`
receives reliable vertical sizing.


&__right {
Expand All @@ -121,6 +122,14 @@
}
}

&__logo {

&,
svg {
height: 100%;
}
}

&__title {
display: none;
font-size: 14px;
Expand Down