DP-3619 Responsive tables support - #111
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughAdds Restables-based responsive table cloning, overflow-aware stacked layouts, clone-specific styling, script wiring, and documentation with table examples and fallback behavior. ChangesResponsive table restacking
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant TablePage
participant tablesjs
participant Restables
participant ResizeObserver
TablePage->>tablesjs: initialize responsive table wrappers
tablesjs->>Restables: enhance eligible tables
ResizeObserver->>tablesjs: report wrapper width changes
tablesjs->>Restables: switch stacked clone visibility
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@assets/scss/dark-theme/tables.scss`:
- Around line 22-24: Update the .restables-clone tbody td:first-child selector
in the dark-theme table styles to set the foreground color to $color-white in
addition to its existing $color-gunpowder-gray background, preserving readable
cloned row labels in dark mode.
In `@docs/tables.md`:
- Line 80: Resolve the broken vertical-header reference in docs/tables.md by
either adding the advertised “Vertical header column” section/example or
removing its link and fallback wording; if removing it, also update the
vertical-header wording in docs/tables.md and align the navigation description
in docs/_index.md with the resulting page content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a5290ec4-5ebb-4627-ae43-f012b32602f8
⛔ Files ignored due to path filters (1)
static/js/restables.min.jsis excluded by!**/*.min.js
📒 Files selected for processing (6)
assets/scss/dark-theme/tables.scssassets/scss/tables.scssdocs/_index.mddocs/tables.mdlayouts/partials/hooks/body-end.htmlstatic/js/tables.js
d7e5981 to
909b0bb
Compare
Summary by CodeRabbit