Skip to content

docs: Rebranding - #1696

Open
czechian wants to merge 2 commits into
gooddata:masterfrom
czechian:rebranding
Open

docs: Rebranding#1696
czechian wants to merge 2 commits into
gooddata:masterfrom
czechian:rebranding

Conversation

@czechian

@czechian czechian commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added dark-mode theme switcher support with improved header/theme script loading.
    • Added JSON-LD structured data for documentation pages.
  • Updates

    • Public documentation builds now run Hugo with hugo_env=public.
    • Switched syntax highlighting to Monokai and tightened Hugo environment-variable access.
    • Refreshed the docs UI: updated navigation/header behavior; removed or disabled several legacy components including offline search indexing, alerts, TOC/prev-next, Swagger UI, sharing, and some homepage sections.
  • Bug Fixes

    • Improved footnote rendering by cleaning endnote markup.

@czechian
czechian requested review from hkad98, lupko and pcerny as code owners July 23, 2026 15:07
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f0a141db-cab3-4a64-824d-a7b05bb3d438

📥 Commits

Reviewing files that changed from the base of the PR and between 59e9dd8 and 9620ac4.

📒 Files selected for processing (1)
  • docs/layouts/partials/hooks/body-end.html
💤 Files with no reviewable changes (1)
  • docs/layouts/partials/hooks/body-end.html

📝 Walkthrough

Walkthrough

Documentation builds now set hugo_env=public, Hugo theme integration and configuration were updated, and navigation, runtime hooks, styling, and content rendering were revised. Legacy documentation layouts, shortcodes, stylesheets, variables, search generation, and scripts were removed.

Changes

Documentation theme migration

Layer / File(s) Summary
Build and theme wiring
.github/..., docs/config/_default/*, docs/go.mod, docs/assets/scss/_styles_project.scss
Build environments, Hugo environment access, syntax highlighting, the theme dependency, and SCSS import ordering were updated.
Navigation and runtime hooks
docs/config/_default/menus.toml, docs/layouts/partials/navbar.html, docs/layouts/partials/hooks/*
A data-driven menu, whitelabeled navigation mode, conditional search, theme switching, Prism CSS loading, structured data, and runtime scripts were added or updated.
Local visual overrides
docs/assets/scss/_local-overrides.scss, docs/assets/scss/_styles_project.scss
Local overrides define header, dark-mode, alert, tooltip, table, and footer styling after theme components are imported.
Content rendering adjustments
docs/layouts/_default/content.html, docs/static/js/tables.js
Footnote markup is post-processed and client-side table wrapping behavior is removed.
Removed legacy documentation layer
docs/layouts/**, docs/assets/scss/**, docs/static/js/**
Legacy layouts, shortcodes, stylesheets, variables, search generation, and JavaScript behavior were removed.

Estimated code review effort: 4 (Complex) | ~45 minutes

Suggested reviewers: hkad98, lupko, pcerny

Poem

I’m a rabbit with a theme-shaped tune,
Styling hops beneath a newer moon.
Menus bloom and dark modes glow,
Hugo env flags help builds flow.
Old page sprites rest in their burrow—
Fresh docs leap ahead in a hurry!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: a broad documentation site rebranding with extensive theme, layout, and styling updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@czechian czechian closed this Jul 23, 2026
@czechian czechian reopened this Jul 23, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/netlify-deploy-v2.yaml:
- Line 129: Remove the lowercase hugo_env YAML key and prefix the Hugo command
with hugo_env=public in .github/workflows/netlify-deploy-v2.yaml at lines
129-129. Apply the same change in
.github/actions/hugo-build-versioned-action/action.yaml at lines 81-81, while
preserving the existing uppercase HUGO_ENV key.

In `@docs/assets/scss/_local-overrides.scss`:
- Line 2: Remove the empty comment from _local-overrides.scss and update the
color keyword spelling to the repository-required lowercase currentcolor
wherever it appears, ensuring the stylesheet passes Stylelint.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ce0777e3-7d97-4771-a165-5eaa142637e5

📥 Commits

Reviewing files that changed from the base of the PR and between 5684211 and 5130f2f.

⛔ Files ignored due to path filters (23)
  • docs/assets/icons/chevron-menu.svg is excluded by !**/*.svg
  • docs/assets/icons/chevron.svg is excluded by !**/*.svg
  • docs/assets/icons/docs-icon.svg is excluded by !**/*.svg
  • docs/assets/icons/slack.svg is excluded by !**/*.svg
  • docs/go.sum is excluded by !**/*.sum
  • docs/static/figures/different-use-cases.png is excluded by !**/*.png
  • docs/static/figures/gd-relationship.png is excluded by !**/*.png
  • docs/static/figures/gd-use-cases.png is excluded by !**/*.png
  • docs/static/img/arrow-right.svg is excluded by !**/*.svg
  • docs/static/img/burger.svg is excluded by !**/*.svg
  • docs/static/img/close.svg is excluded by !**/*.svg
  • docs/static/img/copy.svg is excluded by !**/*.svg
  • docs/static/img/dropdown.svg is excluded by !**/*.svg
  • docs/static/img/icon-accelerator-toolkit.svg is excluded by !**/*.svg
  • docs/static/img/icon-community.svg is excluded by !**/*.svg
  • docs/static/img/icon-examples-gallery.svg is excluded by !**/*.svg
  • docs/static/img/icon-gooddata-ui-documentation.svg is excluded by !**/*.svg
  • docs/static/img/icon-hosted.svg is excluded by !**/*.svg
  • docs/static/img/icon-interactive-code-samples.svg is excluded by !**/*.svg
  • docs/static/img/icon-slack.svg is excluded by !**/*.svg
  • docs/static/img/icon-university.svg is excluded by !**/*.svg
  • docs/static/img/share.svg is excluded by !**/*.svg
  • docs/static/img/video-play.svg is excluded by !**/*.svg
📒 Files selected for processing (77)
  • .github/actions/hugo-build-versioned-action/action.yaml
  • .github/workflows/netlify-deploy-v2.yaml
  • docs/assets/js/base.js
  • docs/assets/json/offline-search-index.json
  • docs/assets/scss/_local-overrides.scss
  • docs/assets/scss/_styles_project.scss
  • docs/assets/scss/alert.scss
  • docs/assets/scss/content-select.scss
  • docs/assets/scss/functions/_functions.pxtorem.scss
  • docs/assets/scss/header.scss
  • docs/assets/scss/homepage.scss
  • docs/assets/scss/homepage/box.scss
  • docs/assets/scss/homepage/hosted.scss
  • docs/assets/scss/homepage/icons.scss
  • docs/assets/scss/homepage/learn.scss
  • docs/assets/scss/homepage/sections-list.scss
  • docs/assets/scss/homepage/slack.scss
  • docs/assets/scss/mixins/_mixins.media-queries.scss
  • docs/assets/scss/prev-next-pages.scss
  • docs/assets/scss/share-dialog.scss
  • docs/assets/scss/swagger.scss
  • docs/assets/scss/tables.scss
  • docs/assets/scss/toc.scss
  • docs/assets/scss/tooltip.scss
  • docs/assets/scss/typography.scss
  • docs/assets/scss/variables/_variables.colors.scss
  • docs/assets/scss/variables/_variables.footer.scss
  • docs/assets/scss/variables/_variables.media-queries.scss
  • docs/assets/scss/variables/_variables.scss
  • docs/config/_default/config.toml
  • docs/config/_default/menus.toml
  • docs/go.mod
  • docs/layouts/404.html
  • docs/layouts/_default/_markup/render-image.html
  • docs/layouts/_default/_markup/render-link.html
  • docs/layouts/_default/baseof.html
  • docs/layouts/_default/content.html
  • docs/layouts/docs/baseof.html
  • docs/layouts/partials/article-label.html
  • docs/layouts/partials/custom-related-content.html
  • docs/layouts/partials/favicons.html
  • docs/layouts/partials/footer.html
  • docs/layouts/partials/gtm-body.html
  • docs/layouts/partials/gtm.html
  • docs/layouts/partials/head-css.html
  • docs/layouts/partials/head.html
  • docs/layouts/partials/header-menu.html
  • docs/layouts/partials/hooks/body-end.html
  • docs/layouts/partials/hooks/head-end.html
  • docs/layouts/partials/navbar.html
  • docs/layouts/partials/prev-next-pages.html
  • docs/layouts/partials/share-dialog.html
  • docs/layouts/partials/toc.html
  • docs/layouts/shortcodes/alert.html
  • docs/layouts/shortcodes/blocks/card.html
  • docs/layouts/shortcodes/blocks/cards-container.html
  • docs/layouts/shortcodes/blocks/feature.html
  • docs/layouts/shortcodes/blocks/homepage-hosted.html
  • docs/layouts/shortcodes/blocks/homepage-learn.html
  • docs/layouts/shortcodes/blocks/homepage-slack.html
  • docs/layouts/shortcodes/blocks/section.html
  • docs/layouts/shortcodes/blocks/sections-list.html
  • docs/layouts/shortcodes/code-lang.html
  • docs/layouts/shortcodes/code-select.html
  • docs/layouts/shortcodes/content-block.html
  • docs/layouts/shortcodes/content-select.html
  • docs/layouts/shortcodes/inline-icon.html
  • docs/layouts/shortcodes/label.html
  • docs/layouts/shortcodes/latest-doc-dirpath.html
  • docs/layouts/shortcodes/latesttag.html
  • docs/layouts/shortcodes/product.html
  • docs/layouts/shortcodes/swaggerui.html
  • docs/layouts/swagger/baseof.html
  • docs/static/js/pactsafe.js
  • docs/static/js/prism.js
  • docs/static/js/share.js
  • docs/static/js/tables.js
💤 Files with no reviewable changes (65)
  • docs/layouts/partials/header-menu.html
  • docs/layouts/partials/gtm-body.html
  • docs/layouts/shortcodes/blocks/homepage-slack.html
  • docs/layouts/shortcodes/code-select.html
  • docs/layouts/partials/toc.html
  • docs/layouts/_default/baseof.html
  • docs/layouts/shortcodes/code-lang.html
  • docs/assets/scss/homepage/slack.scss
  • docs/layouts/partials/article-label.html
  • docs/assets/scss/share-dialog.scss
  • docs/layouts/swagger/baseof.html
  • docs/assets/scss/tables.scss
  • docs/assets/scss/content-select.scss
  • docs/layouts/shortcodes/label.html
  • docs/assets/scss/typography.scss
  • docs/assets/scss/homepage/icons.scss
  • docs/assets/scss/homepage/sections-list.scss
  • docs/assets/scss/alert.scss
  • docs/layouts/shortcodes/blocks/feature.html
  • docs/assets/scss/functions/_functions.pxtorem.scss
  • docs/assets/scss/homepage/hosted.scss
  • docs/layouts/partials/custom-related-content.html
  • docs/assets/scss/header.scss
  • docs/layouts/shortcodes/blocks/homepage-hosted.html
  • docs/assets/scss/prev-next-pages.scss
  • docs/layouts/shortcodes/blocks/cards-container.html
  • docs/static/js/share.js
  • docs/layouts/shortcodes/blocks/homepage-learn.html
  • docs/layouts/partials/favicons.html
  • docs/layouts/partials/share-dialog.html
  • docs/assets/scss/homepage/learn.scss
  • docs/layouts/partials/gtm.html
  • docs/layouts/shortcodes/product.html
  • docs/layouts/_default/_markup/render-image.html
  • docs/layouts/partials/footer.html
  • docs/layouts/shortcodes/alert.html
  • docs/layouts/shortcodes/blocks/card.html
  • docs/layouts/shortcodes/latest-doc-dirpath.html
  • docs/layouts/shortcodes/blocks/section.html
  • docs/layouts/partials/head-css.html
  • docs/assets/scss/mixins/_mixins.media-queries.scss
  • docs/layouts/_default/_markup/render-link.html
  • docs/layouts/shortcodes/content-block.html
  • docs/layouts/docs/baseof.html
  • docs/layouts/shortcodes/blocks/sections-list.html
  • docs/assets/scss/homepage.scss
  • docs/assets/scss/homepage/box.scss
  • docs/layouts/shortcodes/content-select.html
  • docs/assets/json/offline-search-index.json
  • docs/assets/scss/variables/_variables.media-queries.scss
  • docs/assets/scss/toc.scss
  • docs/layouts/partials/prev-next-pages.html
  • docs/static/js/tables.js
  • docs/layouts/shortcodes/swaggerui.html
  • docs/assets/scss/tooltip.scss
  • docs/assets/scss/swagger.scss
  • docs/layouts/404.html
  • docs/layouts/shortcodes/inline-icon.html
  • docs/layouts/shortcodes/latesttag.html
  • docs/layouts/partials/head.html
  • docs/static/js/prism.js
  • docs/static/js/pactsafe.js
  • docs/assets/scss/variables/_variables.footer.scss
  • docs/assets/scss/variables/_variables.scss
  • docs/assets/scss/variables/_variables.colors.scss

Comment thread .github/workflows/netlify-deploy-v2.yaml Outdated
Comment thread docs/assets/scss/_local-overrides.scss Outdated
@@ -0,0 +1,233 @@
// Project-local overrides layered on top of gooddata-docs-theme.
//

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Resolve the reported Stylelint errors.

Remove the empty comment and use the repository-required currentcolor spelling so this stylesheet passes linting.

Proposed fix
-//
...
-            fill: currentColor;
+            fill: currentcolor;

Also applies to: 74-74

🧰 Tools
🪛 Stylelint (17.14.0)

[error] 2-2: Unexpected empty comment (scss/comment-no-empty)

(scss/comment-no-empty)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/assets/scss/_local-overrides.scss` at line 2, Remove the empty comment
from _local-overrides.scss and update the color keyword spelling to the
repository-required lowercase currentcolor wherever it appears, ensuring the
stylesheet passes Stylelint.

Source: Linters/SAST tools

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/assets/scss/_local-overrides.scss`:
- Around line 213-221: Add pointer-events: none to the &::after overlay inside
&__inner so the right-edge gradient does not intercept horizontal scrollbar
interaction.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7ba10f4-2483-41dd-9fde-ddf6fcf8069b

📥 Commits

Reviewing files that changed from the base of the PR and between 5130f2f and 0369aba.

⛔ Files ignored due to path filters (23)
  • docs/assets/icons/chevron-menu.svg is excluded by !**/*.svg
  • docs/assets/icons/chevron.svg is excluded by !**/*.svg
  • docs/assets/icons/docs-icon.svg is excluded by !**/*.svg
  • docs/assets/icons/slack.svg is excluded by !**/*.svg
  • docs/go.sum is excluded by !**/*.sum
  • docs/static/figures/different-use-cases.png is excluded by !**/*.png
  • docs/static/figures/gd-relationship.png is excluded by !**/*.png
  • docs/static/figures/gd-use-cases.png is excluded by !**/*.png
  • docs/static/img/arrow-right.svg is excluded by !**/*.svg
  • docs/static/img/burger.svg is excluded by !**/*.svg
  • docs/static/img/close.svg is excluded by !**/*.svg
  • docs/static/img/copy.svg is excluded by !**/*.svg
  • docs/static/img/dropdown.svg is excluded by !**/*.svg
  • docs/static/img/icon-accelerator-toolkit.svg is excluded by !**/*.svg
  • docs/static/img/icon-community.svg is excluded by !**/*.svg
  • docs/static/img/icon-examples-gallery.svg is excluded by !**/*.svg
  • docs/static/img/icon-gooddata-ui-documentation.svg is excluded by !**/*.svg
  • docs/static/img/icon-hosted.svg is excluded by !**/*.svg
  • docs/static/img/icon-interactive-code-samples.svg is excluded by !**/*.svg
  • docs/static/img/icon-slack.svg is excluded by !**/*.svg
  • docs/static/img/icon-university.svg is excluded by !**/*.svg
  • docs/static/img/share.svg is excluded by !**/*.svg
  • docs/static/img/video-play.svg is excluded by !**/*.svg
📒 Files selected for processing (77)
  • .github/actions/hugo-build-versioned-action/action.yaml
  • .github/workflows/netlify-deploy-v2.yaml
  • docs/assets/js/base.js
  • docs/assets/json/offline-search-index.json
  • docs/assets/scss/_local-overrides.scss
  • docs/assets/scss/_styles_project.scss
  • docs/assets/scss/alert.scss
  • docs/assets/scss/content-select.scss
  • docs/assets/scss/functions/_functions.pxtorem.scss
  • docs/assets/scss/header.scss
  • docs/assets/scss/homepage.scss
  • docs/assets/scss/homepage/box.scss
  • docs/assets/scss/homepage/hosted.scss
  • docs/assets/scss/homepage/icons.scss
  • docs/assets/scss/homepage/learn.scss
  • docs/assets/scss/homepage/sections-list.scss
  • docs/assets/scss/homepage/slack.scss
  • docs/assets/scss/mixins/_mixins.media-queries.scss
  • docs/assets/scss/prev-next-pages.scss
  • docs/assets/scss/share-dialog.scss
  • docs/assets/scss/swagger.scss
  • docs/assets/scss/tables.scss
  • docs/assets/scss/toc.scss
  • docs/assets/scss/tooltip.scss
  • docs/assets/scss/typography.scss
  • docs/assets/scss/variables/_variables.colors.scss
  • docs/assets/scss/variables/_variables.footer.scss
  • docs/assets/scss/variables/_variables.media-queries.scss
  • docs/assets/scss/variables/_variables.scss
  • docs/config/_default/config.toml
  • docs/config/_default/menus.toml
  • docs/go.mod
  • docs/layouts/404.html
  • docs/layouts/_default/_markup/render-image.html
  • docs/layouts/_default/_markup/render-link.html
  • docs/layouts/_default/baseof.html
  • docs/layouts/_default/content.html
  • docs/layouts/docs/baseof.html
  • docs/layouts/partials/article-label.html
  • docs/layouts/partials/custom-related-content.html
  • docs/layouts/partials/favicons.html
  • docs/layouts/partials/footer.html
  • docs/layouts/partials/gtm-body.html
  • docs/layouts/partials/gtm.html
  • docs/layouts/partials/head-css.html
  • docs/layouts/partials/head.html
  • docs/layouts/partials/header-menu.html
  • docs/layouts/partials/hooks/body-end.html
  • docs/layouts/partials/hooks/head-end.html
  • docs/layouts/partials/navbar.html
  • docs/layouts/partials/prev-next-pages.html
  • docs/layouts/partials/share-dialog.html
  • docs/layouts/partials/toc.html
  • docs/layouts/shortcodes/alert.html
  • docs/layouts/shortcodes/blocks/card.html
  • docs/layouts/shortcodes/blocks/cards-container.html
  • docs/layouts/shortcodes/blocks/feature.html
  • docs/layouts/shortcodes/blocks/homepage-hosted.html
  • docs/layouts/shortcodes/blocks/homepage-learn.html
  • docs/layouts/shortcodes/blocks/homepage-slack.html
  • docs/layouts/shortcodes/blocks/section.html
  • docs/layouts/shortcodes/blocks/sections-list.html
  • docs/layouts/shortcodes/code-lang.html
  • docs/layouts/shortcodes/code-select.html
  • docs/layouts/shortcodes/content-block.html
  • docs/layouts/shortcodes/content-select.html
  • docs/layouts/shortcodes/inline-icon.html
  • docs/layouts/shortcodes/label.html
  • docs/layouts/shortcodes/latest-doc-dirpath.html
  • docs/layouts/shortcodes/latesttag.html
  • docs/layouts/shortcodes/product.html
  • docs/layouts/shortcodes/swaggerui.html
  • docs/layouts/swagger/baseof.html
  • docs/static/js/pactsafe.js
  • docs/static/js/prism.js
  • docs/static/js/share.js
  • docs/static/js/tables.js
💤 Files with no reviewable changes (65)
  • docs/layouts/shortcodes/blocks/feature.html
  • docs/layouts/partials/gtm-body.html
  • docs/assets/scss/prev-next-pages.scss
  • docs/layouts/404.html
  • docs/layouts/shortcodes/product.html
  • docs/assets/scss/tooltip.scss
  • docs/layouts/shortcodes/blocks/homepage-hosted.html
  • docs/layouts/partials/gtm.html
  • docs/assets/scss/typography.scss
  • docs/assets/scss/variables/_variables.media-queries.scss
  • docs/assets/json/offline-search-index.json
  • docs/layouts/_default/_markup/render-image.html
  • docs/layouts/shortcodes/alert.html
  • docs/layouts/shortcodes/blocks/cards-container.html
  • docs/layouts/_default/baseof.html
  • docs/layouts/partials/custom-related-content.html
  • docs/layouts/shortcodes/content-select.html
  • docs/layouts/shortcodes/code-lang.html
  • docs/layouts/shortcodes/blocks/homepage-learn.html
  • docs/layouts/shortcodes/code-select.html
  • docs/layouts/shortcodes/inline-icon.html
  • docs/assets/scss/toc.scss
  • docs/layouts/partials/article-label.html
  • docs/layouts/partials/favicons.html
  • docs/layouts/shortcodes/blocks/section.html
  • docs/layouts/shortcodes/blocks/homepage-slack.html
  • docs/layouts/shortcodes/label.html
  • docs/assets/scss/alert.scss
  • docs/assets/scss/content-select.scss
  • docs/layouts/shortcodes/blocks/card.html
  • docs/static/js/tables.js
  • docs/layouts/docs/baseof.html
  • docs/assets/scss/header.scss
  • docs/layouts/shortcodes/latesttag.html
  • docs/layouts/partials/head.html
  • docs/layouts/shortcodes/blocks/sections-list.html
  • docs/assets/scss/homepage/sections-list.scss
  • docs/layouts/shortcodes/swaggerui.html
  • docs/layouts/shortcodes/content-block.html
  • docs/assets/scss/tables.scss
  • docs/layouts/swagger/baseof.html
  • docs/layouts/shortcodes/latest-doc-dirpath.html
  • docs/layouts/_default/_markup/render-link.html
  • docs/layouts/partials/prev-next-pages.html
  • docs/layouts/partials/head-css.html
  • docs/assets/scss/share-dialog.scss
  • docs/assets/scss/homepage.scss
  • docs/assets/scss/homepage/box.scss
  • docs/static/js/share.js
  • docs/assets/scss/homepage/hosted.scss
  • docs/layouts/partials/toc.html
  • docs/layouts/partials/footer.html
  • docs/layouts/partials/share-dialog.html
  • docs/assets/scss/swagger.scss
  • docs/assets/scss/homepage/slack.scss
  • docs/assets/scss/homepage/icons.scss
  • docs/assets/scss/homepage/learn.scss
  • docs/assets/scss/functions/_functions.pxtorem.scss
  • docs/assets/scss/variables/_variables.footer.scss
  • docs/static/js/pactsafe.js
  • docs/assets/scss/mixins/_mixins.media-queries.scss
  • docs/static/js/prism.js
  • docs/layouts/partials/header-menu.html
  • docs/assets/scss/variables/_variables.scss
  • docs/assets/scss/variables/_variables.colors.scss
🚧 Files skipped from review as they are similar to previous changes (6)
  • .github/actions/hugo-build-versioned-action/action.yaml
  • .github/workflows/netlify-deploy-v2.yaml
  • docs/layouts/partials/hooks/body-end.html
  • docs/config/_default/menus.toml
  • docs/config/_default/config.toml
  • docs/assets/scss/_styles_project.scss

Comment on lines +213 to +221
&::after {
content: "";
position: absolute;
top: 0;
right: 0;
bottom: 0;
width: 20px;
background: linear-gradient(90deg, rgba($color-white, 0) 0%, rgba($color-white, 1) 100%);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Do not block the horizontal scrollbar.

This overlay sits above &__inner’s right edge and accepts pointer events, preventing interaction with the scrollbar underneath. Add pointer-events: none.

Proposed fix
         &::after {
             content: "";
             position: absolute;
             top: 0;
             right: 0;
             bottom: 0;
             width: 20px;
+            pointer-events: none;
             background: linear-gradient(90deg, rgba($color-white, 0) 0%, rgba($color-white, 1) 100%);
         }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
&::after {
content: "";
position: absolute;
top: 0;
right: 0;
bottom: 0;
width: 20px;
background: linear-gradient(90deg, rgba($color-white, 0) 0%, rgba($color-white, 1) 100%);
}
&::after {
content: "";
position: absolute;
top: 0;
right: 0;
bottom: 0;
width: 20px;
pointer-events: none;
background: linear-gradient(90deg, rgba($color-white, 0) 0%, rgba($color-white, 1) 100%);
}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/assets/scss/_local-overrides.scss` around lines 213 - 221, Add
pointer-events: none to the &::after overlay inside &__inner so the right-edge
gradient does not intercept horizontal scrollbar interaction.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
docs/assets/scss/_styles_project.scss (1)

36-42: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Make the dark-theme import actually last.

The dark-theme import at Lines 41-42 is followed by #print and .gd-footer rules through Line 85, so its source-order guarantee is not absolute. Move the import below the footer block, or narrow the comment, and verify any overlapping dark-footer declarations.

Also applies to: 56-84

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/assets/scss/_styles_project.scss` around lines 36 - 42, Move the
dark-theme `@import` in the stylesheet below the `#print` and .gd-footer rules so it
is genuinely last and its dark-mode declarations take precedence. Keep the
existing footer styles intact and verify overlapping dark-footer rules still
resolve correctly after the reorder.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@docs/assets/scss/_styles_project.scss`:
- Around line 36-42: Move the dark-theme `@import` in the stylesheet below the
`#print` and .gd-footer rules so it is genuinely last and its dark-mode
declarations take precedence. Keep the existing footer styles intact and verify
overlapping dark-footer rules still resolve correctly after the reorder.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7e013f17-62ec-4062-9ca1-1e969f38b943

📥 Commits

Reviewing files that changed from the base of the PR and between 0369aba and 59e9dd8.

⛔ Files ignored due to path filters (23)
  • docs/assets/icons/chevron-menu.svg is excluded by !**/*.svg
  • docs/assets/icons/chevron.svg is excluded by !**/*.svg
  • docs/assets/icons/docs-icon.svg is excluded by !**/*.svg
  • docs/assets/icons/slack.svg is excluded by !**/*.svg
  • docs/go.sum is excluded by !**/*.sum
  • docs/static/figures/different-use-cases.png is excluded by !**/*.png
  • docs/static/figures/gd-relationship.png is excluded by !**/*.png
  • docs/static/figures/gd-use-cases.png is excluded by !**/*.png
  • docs/static/img/arrow-right.svg is excluded by !**/*.svg
  • docs/static/img/burger.svg is excluded by !**/*.svg
  • docs/static/img/close.svg is excluded by !**/*.svg
  • docs/static/img/copy.svg is excluded by !**/*.svg
  • docs/static/img/dropdown.svg is excluded by !**/*.svg
  • docs/static/img/icon-accelerator-toolkit.svg is excluded by !**/*.svg
  • docs/static/img/icon-community.svg is excluded by !**/*.svg
  • docs/static/img/icon-examples-gallery.svg is excluded by !**/*.svg
  • docs/static/img/icon-gooddata-ui-documentation.svg is excluded by !**/*.svg
  • docs/static/img/icon-hosted.svg is excluded by !**/*.svg
  • docs/static/img/icon-interactive-code-samples.svg is excluded by !**/*.svg
  • docs/static/img/icon-slack.svg is excluded by !**/*.svg
  • docs/static/img/icon-university.svg is excluded by !**/*.svg
  • docs/static/img/share.svg is excluded by !**/*.svg
  • docs/static/img/video-play.svg is excluded by !**/*.svg
📒 Files selected for processing (77)
  • .github/actions/hugo-build-versioned-action/action.yaml
  • .github/workflows/netlify-deploy-v2.yaml
  • docs/assets/js/base.js
  • docs/assets/json/offline-search-index.json
  • docs/assets/scss/_local-overrides.scss
  • docs/assets/scss/_styles_project.scss
  • docs/assets/scss/alert.scss
  • docs/assets/scss/content-select.scss
  • docs/assets/scss/functions/_functions.pxtorem.scss
  • docs/assets/scss/header.scss
  • docs/assets/scss/homepage.scss
  • docs/assets/scss/homepage/box.scss
  • docs/assets/scss/homepage/hosted.scss
  • docs/assets/scss/homepage/icons.scss
  • docs/assets/scss/homepage/learn.scss
  • docs/assets/scss/homepage/sections-list.scss
  • docs/assets/scss/homepage/slack.scss
  • docs/assets/scss/mixins/_mixins.media-queries.scss
  • docs/assets/scss/prev-next-pages.scss
  • docs/assets/scss/share-dialog.scss
  • docs/assets/scss/swagger.scss
  • docs/assets/scss/tables.scss
  • docs/assets/scss/toc.scss
  • docs/assets/scss/tooltip.scss
  • docs/assets/scss/typography.scss
  • docs/assets/scss/variables/_variables.colors.scss
  • docs/assets/scss/variables/_variables.footer.scss
  • docs/assets/scss/variables/_variables.media-queries.scss
  • docs/assets/scss/variables/_variables.scss
  • docs/config/_default/config.toml
  • docs/config/_default/menus.toml
  • docs/go.mod
  • docs/layouts/404.html
  • docs/layouts/_default/_markup/render-image.html
  • docs/layouts/_default/_markup/render-link.html
  • docs/layouts/_default/baseof.html
  • docs/layouts/_default/content.html
  • docs/layouts/docs/baseof.html
  • docs/layouts/partials/article-label.html
  • docs/layouts/partials/custom-related-content.html
  • docs/layouts/partials/favicons.html
  • docs/layouts/partials/footer.html
  • docs/layouts/partials/gtm-body.html
  • docs/layouts/partials/gtm.html
  • docs/layouts/partials/head-css.html
  • docs/layouts/partials/head.html
  • docs/layouts/partials/header-menu.html
  • docs/layouts/partials/hooks/body-end.html
  • docs/layouts/partials/hooks/head-end.html
  • docs/layouts/partials/navbar.html
  • docs/layouts/partials/prev-next-pages.html
  • docs/layouts/partials/share-dialog.html
  • docs/layouts/partials/toc.html
  • docs/layouts/shortcodes/alert.html
  • docs/layouts/shortcodes/blocks/card.html
  • docs/layouts/shortcodes/blocks/cards-container.html
  • docs/layouts/shortcodes/blocks/feature.html
  • docs/layouts/shortcodes/blocks/homepage-hosted.html
  • docs/layouts/shortcodes/blocks/homepage-learn.html
  • docs/layouts/shortcodes/blocks/homepage-slack.html
  • docs/layouts/shortcodes/blocks/section.html
  • docs/layouts/shortcodes/blocks/sections-list.html
  • docs/layouts/shortcodes/code-lang.html
  • docs/layouts/shortcodes/code-select.html
  • docs/layouts/shortcodes/content-block.html
  • docs/layouts/shortcodes/content-select.html
  • docs/layouts/shortcodes/inline-icon.html
  • docs/layouts/shortcodes/label.html
  • docs/layouts/shortcodes/latest-doc-dirpath.html
  • docs/layouts/shortcodes/latesttag.html
  • docs/layouts/shortcodes/product.html
  • docs/layouts/shortcodes/swaggerui.html
  • docs/layouts/swagger/baseof.html
  • docs/static/js/pactsafe.js
  • docs/static/js/prism.js
  • docs/static/js/share.js
  • docs/static/js/tables.js
💤 Files with no reviewable changes (65)
  • docs/layouts/partials/gtm-body.html
  • docs/layouts/partials/favicons.html
  • docs/assets/scss/tables.scss
  • docs/layouts/shortcodes/blocks/homepage-hosted.html
  • docs/layouts/partials/gtm.html
  • docs/layouts/shortcodes/latest-doc-dirpath.html
  • docs/layouts/shortcodes/code-select.html
  • docs/layouts/docs/baseof.html
  • docs/assets/scss/homepage/box.scss
  • docs/layouts/partials/toc.html
  • docs/layouts/shortcodes/blocks/homepage-learn.html
  • docs/layouts/_default/baseof.html
  • docs/assets/scss/prev-next-pages.scss
  • docs/layouts/shortcodes/label.html
  • docs/layouts/shortcodes/blocks/card.html
  • docs/assets/scss/homepage.scss
  • docs/assets/scss/homepage/hosted.scss
  • docs/assets/json/offline-search-index.json
  • docs/layouts/shortcodes/latesttag.html
  • docs/layouts/swagger/baseof.html
  • docs/assets/scss/content-select.scss
  • docs/assets/scss/alert.scss
  • docs/static/js/share.js
  • docs/layouts/shortcodes/blocks/cards-container.html
  • docs/assets/scss/tooltip.scss
  • docs/layouts/_default/_markup/render-link.html
  • docs/layouts/shortcodes/blocks/feature.html
  • docs/layouts/shortcodes/alert.html
  • docs/assets/scss/homepage/sections-list.scss
  • docs/layouts/shortcodes/product.html
  • docs/assets/scss/toc.scss
  • docs/layouts/shortcodes/content-select.html
  • docs/layouts/partials/share-dialog.html
  • docs/assets/scss/variables/_variables.media-queries.scss
  • docs/layouts/404.html
  • docs/layouts/shortcodes/content-block.html
  • docs/layouts/partials/article-label.html
  • docs/layouts/shortcodes/inline-icon.html
  • docs/layouts/partials/header-menu.html
  • docs/assets/scss/header.scss
  • docs/layouts/partials/footer.html
  • docs/layouts/_default/_markup/render-image.html
  • docs/assets/scss/functions/_functions.pxtorem.scss
  • docs/assets/scss/homepage/icons.scss
  • docs/layouts/shortcodes/code-lang.html
  • docs/static/js/prism.js
  • docs/assets/scss/typography.scss
  • docs/assets/scss/homepage/learn.scss
  • docs/layouts/partials/head.html
  • docs/layouts/shortcodes/blocks/sections-list.html
  • docs/layouts/shortcodes/blocks/section.html
  • docs/assets/scss/swagger.scss
  • docs/assets/scss/mixins/_mixins.media-queries.scss
  • docs/assets/scss/variables/_variables.footer.scss
  • docs/static/js/tables.js
  • docs/static/js/pactsafe.js
  • docs/layouts/partials/custom-related-content.html
  • docs/layouts/partials/prev-next-pages.html
  • docs/layouts/shortcodes/blocks/homepage-slack.html
  • docs/assets/scss/share-dialog.scss
  • docs/assets/scss/variables/_variables.scss
  • docs/assets/scss/variables/_variables.colors.scss
  • docs/layouts/shortcodes/swaggerui.html
  • docs/assets/scss/homepage/slack.scss
  • docs/layouts/partials/head-css.html
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/actions/hugo-build-versioned-action/action.yaml
  • docs/config/_default/menus.toml

The bumped gooddata-docs-theme no longer ships static/js/tab-order.js
(its tab-order fix moved into markup), so the tag 404ed on every page.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant