Skip to content

ci: add extra cluster input on retagging to stable workflow - #2087

Merged
santos1709 merged 1 commit into
masterfrom
lcm-bricks-retag-fup
Jul 29, 2026
Merged

ci: add extra cluster input on retagging to stable workflow#2087
santos1709 merged 1 commit into
masterfrom
lcm-bricks-retag-fup

Conversation

@santos1709

@santos1709 santos1709 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This PR adds missing cluster list on workflow that promotes tag to stable via retagging

Summary by CodeRabbit

  • New Features

    • Added a required cluster selection option when manually running the stable retagging workflow (with an “all clusters” choice).
    • Retagging now targets either the selected cluster or all configured clusters.
  • Improvements

    • Added validation for the chosen cluster; unsupported selections now stop the run with an error.
    • Retag targeting behavior updates accordingly based on the selection.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@santos1709, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 06b8b292-6cd5-435f-b151-43bc47f6f7f6

📥 Commits

Reviewing files that changed from the base of the PR and between e0df8a8 and aaf38ab.

📒 Files selected for processing (1)
  • .github/workflows/lcm-stable-retag.yaml
📝 Walkthrough

Walkthrough

The stable retag workflow adds a required cluster selector, updates its run name, validates the selection, and retags either one matching cluster or all configured clusters.

Changes

Stable retagging workflow

Layer / File(s) Summary
Cluster selection and retagging
.github/workflows/lcm-stable-retag.yaml
Adds enumerated dispatch choices, includes the selected cluster in the run name, validates the selection, and conditionally targets M<major>-<target_cluster> or all configured clusters.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a rabbit with tags in a row,
Picking one cluster where images should go.
Or hopping through all when “all” is the call,
Checking each choice before the tags fall.
Sniff, stamp, retag—done!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: adding a cluster input to the stable retag workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/lcm-stable-retag.yaml:
- Around line 11-24: Synchronize the cluster choices in the workflow’s input
configuration with the env.clusters list used by the membership check: either
add bom1 to env.clusters or remove bom1 from the selectable options, ensuring
bom1 cannot be treated as an unsupported “all clusters” case.
- Around line 92-94: Update the cluster membership check in the retagging logic
to reference the initialized `clusters` array instead of the undefined `cluster`
variable. Preserve the existing target_cluster matching behavior and tagging
flow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d092d43-8ce3-4b3d-8631-483e94531217

📥 Commits

Reviewing files that changed from the base of the PR and between f0dd25a and 3c319b8.

📒 Files selected for processing (1)
  • .github/workflows/lcm-stable-retag.yaml

Comment thread .github/workflows/lcm-stable-retag.yaml Outdated
Comment thread .github/workflows/lcm-stable-retag.yaml Outdated
@santos1709
santos1709 force-pushed the lcm-bricks-retag-fup branch from 3c319b8 to 68e3440 Compare July 28, 2026 10:30
@santos1709

santos1709 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@jiri-staroba jiri-staroba left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of the new cluster input handling. Overall the retagging logic is correct; a few consistency/correctness nits inline.

Two additional notes on lines outside the diff (GitHub won't let me anchor inline comments there):

  • Summary step (line ~117, **Clusters** | ${clusters[*]}): this unconditionally reports the full clusters list from env.clusters, regardless of which cluster was actually targeted. After this change, a run that retags only e.g. na1 will still produce a job summary claiming all 8 clusters were processed. Consider passing the resolved target_cluster (or "all") through to this step and reporting that instead, so the summary matches what actually happened.
  • run-name (line 2, optional/minor): still only shows ${{ inputs.tag }} and not which cluster (or "all") was selected — could be "Retag stable lcm-bricks ${{ inputs.tag }} → M<major>-${{ inputs.cluster }}" for better UX given this PR's whole point is cluster selection.

Comment thread .github/workflows/lcm-stable-retag.yaml Outdated
Comment thread .github/workflows/lcm-stable-retag.yaml Outdated
Comment thread .github/workflows/lcm-stable-retag.yaml Outdated
@santos1709
santos1709 force-pushed the lcm-bricks-retag-fup branch from 68e3440 to 3c546d7 Compare July 28, 2026 13:31

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/lcm-stable-retag.yaml:
- Around line 98-104: Update the workflow Summary step to accurately report the
retagged scope: when target_cluster is not “all”, display the selected target
cluster, while preserving the all-clusters behavior; alternatively, explicitly
label the existing all-cluster value as “Configured clusters.”
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7e80f37d-e59e-4307-8651-9d0edac02f54

📥 Commits

Reviewing files that changed from the base of the PR and between 3c319b8 and 3c546d7.

📒 Files selected for processing (1)
  • .github/workflows/lcm-stable-retag.yaml

Comment thread .github/workflows/lcm-stable-retag.yaml Outdated
@santos1709
santos1709 force-pushed the lcm-bricks-retag-fup branch from 3c546d7 to e0df8a8 Compare July 29, 2026 08:21

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/lcm-stable-retag.yaml:
- Line 24: Update the all-cluster sentinel comparisons in the workflow’s
validation and branching logic to consistently use the exposed `all-clusters`
value, including the referenced script sections. Preserve the existing retagging
behavior for individual clusters and ensure selecting `all-clusters` passes
validation and triggers all-cluster processing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 43331085-8ad9-475e-a68b-8e981ef5d47d

📥 Commits

Reviewing files that changed from the base of the PR and between 3c546d7 and e0df8a8.

📒 Files selected for processing (1)
  • .github/workflows/lcm-stable-retag.yaml

Comment thread .github/workflows/lcm-stable-retag.yaml
@santos1709
santos1709 requested a review from jiri-staroba July 29, 2026 08:26
@santos1709
santos1709 force-pushed the lcm-bricks-retag-fup branch from e0df8a8 to aaf38ab Compare July 29, 2026 09:08
@santos1709
santos1709 added this pull request to the merge queue Jul 29, 2026
Merged via the queue into master with commit 0fb7021 Jul 29, 2026
27 of 28 checks passed
@santos1709
santos1709 deleted the lcm-bricks-retag-fup branch July 29, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants