ci: add extra cluster input on retagging to stable workflow - #2087
Conversation
|
Warning Review limit reached
Next review available in: 12 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe stable retag workflow adds a required cluster selector, updates its run name, validates the selection, and retags either one matching cluster or all configured clusters. ChangesStable retagging workflow
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lcm-stable-retag.yaml:
- Around line 11-24: Synchronize the cluster choices in the workflow’s input
configuration with the env.clusters list used by the membership check: either
add bom1 to env.clusters or remove bom1 from the selectable options, ensuring
bom1 cannot be treated as an unsupported “all clusters” case.
- Around line 92-94: Update the cluster membership check in the retagging logic
to reference the initialized `clusters` array instead of the undefined `cluster`
variable. Preserve the existing target_cluster matching behavior and tagging
flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9d092d43-8ce3-4b3d-8631-483e94531217
📒 Files selected for processing (1)
.github/workflows/lcm-stable-retag.yaml
3c319b8 to
68e3440
Compare
|
dry-run test with |
jiri-staroba
left a comment
There was a problem hiding this comment.
Review of the new cluster input handling. Overall the retagging logic is correct; a few consistency/correctness nits inline.
Two additional notes on lines outside the diff (GitHub won't let me anchor inline comments there):
- Summary step (line ~117,
**Clusters** | ${clusters[*]}): this unconditionally reports the fullclusterslist fromenv.clusters, regardless of which cluster was actually targeted. After this change, a run that retags only e.g.na1will still produce a job summary claiming all 8 clusters were processed. Consider passing the resolvedtarget_cluster(or"all") through to this step and reporting that instead, so the summary matches what actually happened. run-name(line 2, optional/minor): still only shows${{ inputs.tag }}and not which cluster (or "all") was selected — could be"Retag stable lcm-bricks ${{ inputs.tag }} → M<major>-${{ inputs.cluster }}"for better UX given this PR's whole point is cluster selection.
68e3440 to
3c546d7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lcm-stable-retag.yaml:
- Around line 98-104: Update the workflow Summary step to accurately report the
retagged scope: when target_cluster is not “all”, display the selected target
cluster, while preserving the all-clusters behavior; alternatively, explicitly
label the existing all-cluster value as “Configured clusters.”
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 7e80f37d-e59e-4307-8651-9d0edac02f54
📒 Files selected for processing (1)
.github/workflows/lcm-stable-retag.yaml
3c546d7 to
e0df8a8
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lcm-stable-retag.yaml:
- Line 24: Update the all-cluster sentinel comparisons in the workflow’s
validation and branching logic to consistently use the exposed `all-clusters`
value, including the referenced script sections. Preserve the existing retagging
behavior for individual clusters and ensure selecting `all-clusters` passes
validation and triggers all-cluster processing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 43331085-8ad9-475e-a68b-8e981ef5d47d
📒 Files selected for processing (1)
.github/workflows/lcm-stable-retag.yaml
e0df8a8 to
aaf38ab
Compare
This PR adds missing
clusterlist on workflow that promotes tag to stable via retaggingSummary by CodeRabbit
New Features
Improvements