fix(policies): keep invalid actions masked during sampling - #121
Open
Linxiushen wants to merge 1 commit into
Open
Linxiushen wants to merge 1 commit into
Linxiushen wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Linxiushen
force-pushed
the
fix/mask-final-muzero-actions
branch
from
September 28, 2026 03:50
ee5538b to
54cba84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At high temperatures,
muzero_policyandstochastic_muzero_policycan return an action marked invalid even though the search never visits it. Zero visit probabilities are clipped to the dtype's finitetinyvalue before taking logs; temperature scaling then gives these actions nonzero sampling probability. With temperature 100 and one valid action per row, a deterministic 32-row example returns 17 invalid actions.Reapply the existing invalid-action mask after temperature scaling and before the final categorical sample in both policies. Search results and the returned training weights remain unchanged.
The regressions run real MuZero and stochastic MuZero searches, with a different valid action across rows, both directly and under JIT, at temperatures 0, 1, and 100. On unchanged main, the four high-temperature cases fail and eight controls pass. With the fix, the full test suite passes: 36 passed on Windows Python 3.12.13 / JAX 0.11.2 CPU, run from the
_testingdirectory prescribed bytest.sh.The CI flake8 selector passes repository-wide, production-file Pylint passes, and wheel/sdist builds succeed. The configured test Pylint and Ruff checks retain one pre-existing long-line diagnostic each, outside the modified code; no new findings. Pyink passes for the added test block. No GPU/TPU, training run, Linux run, or supported-Python matrix is claimed.