Cherry-Pick Fix file already exist error while running substitute in Docker into version-1.55-dev - #2940
Draft
k311093 wants to merge 1 commit into
Draft
Cherry-Pick Fix file already exist error while running substitute in Docker into version-1.55-dev#2940k311093 wants to merge 1 commit into
k311093 wants to merge 1 commit into
Conversation
k311093
force-pushed
the
version-1.55-dev
branch
from
July 31, 2026 07:20
ee3a6de to
685e294
Compare
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
In the OverlayFS, even if unlink() is succeeded, looks like there is a delay between unlink call and the file is actually disappears. Change to use rename call which ensures atomic operation for substitution.
k311093
force-pushed
the
version-1.55-dev
branch
from
August 3, 2026 04:17
685e294 to
1f176ec
Compare
0405ysj
self-requested a review
August 3, 2026 05:20
0405ysj
approved these changes
Aug 3, 2026
0405ysj
left a comment
0405ysj
left a comment
Collaborator
There was a problem hiding this comment.
Does it need to modify base/cvd/cuttlefish/host/commands/cvd/fetch/BUILD.bazel as https://github.com/google/android-cuttlefish/pull/2885/changes? Otherwise, LGTM.
Collaborator
|
Also could we import this patch under |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the OverlayFS, even if unlink() is succeeded, looks like there is a delay between unlink call and the file is actually disappears.
Change to use rename call which ensures atomic operation for substitution.