Add an optional A/B pvmfw partition to the OS composite disk - #2953
Open
dimorinny wants to merge 1 commit into
Open
Add an optional A/B pvmfw partition to the OS composite disk#2953dimorinny wants to merge 1 commit into
dimorinny wants to merge 1 commit into
Conversation
The image comes from --pvmfw_image or the Android build when available. Targets that don't build protected VM firmware are unaffected. Bug: 536088107 Signed-off-by: Dmitrii Merkurev <dimorinny@google.com>
Databean
approved these changes
Aug 3, 2026
Comment on lines
+32
to
+36
| DEFINE_string(pvmfw_image, CF_DEFAULTS_PVMFW_IMAGE, | ||
| "Location of the cuttlefish protected VM firmware image. If not " | ||
| "given it is taken from pvmfw.img in the directory specified by " | ||
| "-system_image_dir, when that file is present. If given, the " | ||
| "file must exist."); |
Member
There was a problem hiding this comment.
Are there scenarios where this file is built separately from the Android build system and a custom version needs to be tested? Would rather avoid adding a new flag if it's not going to be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image comes from --pvmfw_image or the Android build when available. Targets that don't build protected VM firmware are unaffected.
Bug: 536088107