Migrate remaining native rules for Bazel 9 - #174
Draft
dzbarsky wants to merge 1 commit into
Draft
Conversation
Load C++, Java, proto, and shell rules explicitly in the remaining GoogleSQL BUILD files and BUILD overlays. Declare rules_shell in the root module and rules_cc in the example module, and replace native.sh_test in execute_query_test. Add the temporary C++/proto autoload fallback for unchanged third-party BUILD files in both Bazel configurations. Adapt GoogleCloudPlatform/cloud-spanner-emulator#374 to GoogleSQL. Keep the pinned Bazel 7.6.1 version; GoogleSQL has no JavaCC changes. Validation: package-loading queries pass for GoogleSQL and its example under Bazel 7.6.1. A separate Bazel 9.0.0 consumer passes with a test-only rules_swift 3.1.2 override. Ordinary Bazel 9 module resolution remains blocked by the existing gRPC/Bazel rules_swift compatibility mismatch; the override is not part of this change. No compilation or runtime tests were run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt cloud-spanner-emulator#374 to GoogleSQL: explicitly load the remaining C++, Java, proto, and shell rules in GoogleSQL-owned BUILD files, BUILD overlays, and
execute_query_test; declare the required module dependencies; and add the temporary autoload fallback for unchanged third-party BUILD files. Include the separate Bazel example and keep the pinned Bazel 7.6.1 version. GoogleSQL uses Textmapper, so the emulator's JavaCC changes are not included.Validation: package-loading queries pass for GoogleSQL and its example under Bazel 7.6.1, and for a separate Bazel 9.0.0 consumer with a test-only
rules_swift3.1.2 override. Ordinary Bazel 9 resolution is blocked by the existing gRPC/Bazelrules_swiftcompatibility-level mismatch; the override is not included in this PR. Compilation and runtime tests were not run.Tracking issue: #177.
GoogleSQL's contribution guide asks for issues rather than external code contributions. This draft provides the proposed implementation for maintainers to incorporate internally. Consuming root modules do not inherit GoogleSQL's
.bazelrcand may still need the third-party autoload flag.-zbarskybot