Prevent showing the same PDF for different submissions of the same LOI - #3862
Open
andreia-ferreira wants to merge 2 commits into
Open
Prevent showing the same PDF for different submissions of the same LOI#3862andreia-ferreira wants to merge 2 commits into
andreia-ferreira wants to merge 2 commits into
Conversation
andreia-ferreira
requested a deployment
to
e2e-approval
July 28, 2026 15:02 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an edge case where, after a certain submission, if another one was completed within 1 minute, with the same LOI name, the same PDF report as the previous one would show.
This PR fixes that by appending the unique submissionID to the name of the file so that the same report is no longer re-used, as the file names will be different even if the loiName is the same.
@shobhitagarwal1612 PTAL?