Fix HEIF/AVIF output buffer overflow - #448
Open
gregbenz wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Contributor
Author
|
@DichenZhang1 FYI that this was flagged by the google-cla check, which is pretty odd as I've done that, contributed, and other PRs sent yesterday were not flagged. Not sure why this one was, but seems incorrectly flagged by that bot. Perhaps that automatic build was a factor? It appears to have been a transient build/test issue (Error: socket hang up) |
gregbenz
force-pushed
the
codex/harden-heif-avif-output-writer
branch
from
August 15, 2026 01:34
869af7a to
3b7da0b
Compare
DichenZhang1
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
heif_context_write().Why
The HEIF and AVIF encoders copied the complete encoded file into the destination without checking its capacity. An undersized destination could therefore be overwritten while the encoder reported success. The encoder now returns
UHDR_CODEC_MEM_ERRORwithout modifying the destination buffer.Testing
-fno-exceptionsand warnings as errors.