Skip to content

Support wiping persistent storage in Web UI - #1155

Merged
ia0 merged 2 commits into
google:mainfrom
ia0:wipe-storage
Sep 30, 2026
Merged

ia0 merged 2 commits into
google:mainfrom
ia0:wipe-storage

Conversation

@ia0

@ia0 ia0 commented Sep 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@ia0 ia0 added for:usability Improves users (and maintainers) life crate:webui Modifies the web UI labels Sep 30, 2026
ia0-review
ia0-review previously approved these changes Sep 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for wiping persistent storage in the WebUI by implementing the PlatformWipeStorage command and updating .gitignore to ignore /dist.trunk-lock. Feedback was provided regarding a compilation error in the newly added PlatformWipeStorage command, where the conditional branches return different types; a suggestion was made to map the responses to a uniform type to resolve the issue.

Comment thread crates/webui/src/page.rs
@ia0
ia0 merged commit 5f25610 into google:main Sep 30, 2026
41 checks passed
@ia0
ia0 deleted the wipe-storage branch September 30, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crate:webui Modifies the web UI for:usability Improves users (and maintainers) life

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants