ci: check user-facing crate semver - #1156
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new SemVer compatibility check for user-facing published crates (board, scheduler, and prelude) using cargo-semver-checks. The feedback recommends improving the robustness of the version extraction logic in scripts/ci-semver.sh by handling potential formatting variations in Cargo.toml and ensuring that version parsing failures do not silently bypass the SemVer checks.
Signed-off-by: mnkj0021 <98058999+mnkj0021@users.noreply.github.com>
ia0-review
approved these changes
Oct 2, 2026
ia0
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #573.
Adds
cargo-semver-checksto the existing wrapper/cache flow and a dedicated PR CI check for the user-facing crates requested in the issue discussion:wasefire-board-api(crates/board)wasefire-scheduler(crates/scheduler)wasefire(crates/prelude)The check compares a crate whose version changed against the pull request base revision, using the public feature sets represented by each crate's docs configuration. Unchanged crates are skipped. It is also wired into
scripts/ci.shfor local use.Validation:
sh -n scripts/ci-semver.sh scripts/ci.sh scripts/wrapper.sh: passed./scripts/ci-copyright.sh: passed./scripts/ci-semver.sh <upstream-main>: passed; all three unchanged crates skipped as expectedImpossible::unreachablefrom board with a patch bump: failed as expected withinherent_method_missing, requiring a major version bumpgit diff --check: passed./scripts/ci-changelog.sh: not completed locally because this VPS lacks the systemlibudevdevelopment package required by the xtask dependency graphAI coding-assistant assistance was used while preparing and validating this contribution. I reviewed the final diff and validation results and take responsibility for the submission.