test(regrid): Add robust OS-level memory leak tracking to Regrid pipeline - #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, we identified a C-level memory leak in our code caused by the native
fs.base_date()method when processing GRIB files, which was fixed in #550. This PR introduces automated tests to explicitly check for and catch any such instances of C-level memory leaks in the Regrid pipeline beforehand.Testing Performed
fs.base_date()) correctly triggers the newAssertionErrordue to ballooning memory.get_memory_safe_base_date(fs)keeps memory growth under the 10.0 MB threshold across multiple test iterations.