Skip to content

fix: support Cargo workspace-inherited versions - #2895

Open
pentaoa wants to merge 1 commit into
googleapis:mainfrom
pentaoa:fix/2111-cargo-workspace-inherited-version
Open

fix: support Cargo workspace-inherited versions#2895
pentaoa wants to merge 1 commit into
googleapis:mainfrom
pentaoa:fix/2111-cargo-workspace-inherited-version

Conversation

@pentaoa

@pentaoa pentaoa commented Sep 5, 2026

Copy link
Copy Markdown
  • An issue describes the bug and expected behavior
  • Tests and linter pass
  • Code coverage does not decrease
  • No documentation change is needed

Fixes #2111 🦕

Summary

  • resolve version.workspace = true members from [workspace.package].version
  • preserve the inheritance declaration when updating member manifests
  • update [workspace.package].version in virtual workspace roots
  • report conflicting release versions for crates that inherit the same workspace version

Testing

  • npm test (1212 passing)
  • npm run lint (passes; existing repository warnings remain)

@pentaoa
pentaoa requested review from a team as code owners September 5, 2026 04:14
@google-cla

google-cla Bot commented Sep 5, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Sep 5, 2026
@pentaoa
pentaoa force-pushed the fix/2111-cargo-workspace-inherited-version branch from 9ca4758 to de2f434 Compare September 7, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cargo-workspace plugin can't handle version.workspace

1 participant