Allow to configure log format in helm chart - #1600
Open
zifter wants to merge 2 commits into
Open
Conversation
zifter
requested review from
HazWard,
aLekSer,
amg84,
calebatwd,
joeholley,
markmandel,
sawagh and
scosgrave
as code owners
October 4, 2023 12:25
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
zifter
force-pushed
the
feature/allow-to-configure-log-format
branch
from
October 4, 2023 12:29
43dd27b to
3865315
Compare
zifter
force-pushed
the
feature/allow-to-configure-log-format
branch
from
October 4, 2023 12:53
3865315 to
7459ccc
Compare
Author
|
How to understand, what's going wrong with build? |
Author
|
@aLekSer can you help with ci issiues? |
zifter
requested review from
ashutosji,
govargo,
kazshinohara and
kemurayama
as code owners
February 26, 2024 16:55
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
I would like to print json log format
Which issue(s) this PR fixes:
At that moment this is no opportunity to configure json log format. This pr make it possible.
Special notes for your reviewer: