Skip to content

build: stop bundling the higher career venue packs - #123

Merged
byrongamatos merged 1 commit into
got-feedBack:mainfrom
mhglover:feat/venue-packs-opt-in
Jul 22, 2026
Merged

build: stop bundling the higher career venue packs#123
byrongamatos merged 1 commit into
got-feedBack:mainfrom
mhglover:feat/venue-packs-opt-in

Conversation

@mhglover

@mhglover mhglover commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Ready for review — part of the nightly-slimming effort (#122). Companion to the core PR (feedBack#1023); merge that first.

Strips club and arena venue media (~678 MB of crowd MP4s) from the desktop bundle — they download on demand from their content-pack releases once the core PR lands. The bar starter stays bundled so career works offline out of the box.

What's here

One targeted strip in scripts/bundle-slopsmith.sh, after the plugin copy loop (mirrors the existing user-data strip): removes venue-packs/club and venue-packs/arena, keeps bar.

Verification

Simulated bundle tree → strip lines → bar kept, club + arena removed. ✅ (Full desktop build not yet run end-to-end.)

Depends on

Core PR feedBack#1023 — sets the pack download URLs. Without it, a stripped venue would have nowhere to download from.

Summary by CodeRabbit

  • New Features
    • Offline installations now include the starter-bar venue by default.
    • Additional career venues, including club and arena venues, are available for download on demand when needed.

Strip club and arena venue media (~678 MB of crowd MP4s) from the desktop
bundle; they download on demand from their content-pack releases. The bar
starter stays bundled so career works offline out of the box.

Companion to the core PR (career: host higher venues as opt-in content
packs). Part of the nightly-slimming effort (#122).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Slopsmith bundling script now removes the club and arena career venue packs from bundled output, leaving those higher-tier venues to be downloaded at runtime.

Changes

Career venue bundling

Layer / File(s) Summary
Remove higher-tier venue packs
scripts/bundle-slopsmith.sh
Adds cleanup steps that delete the bundled club and arena career venue directories.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: byrongamatos, omikronapex

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing higher career venue packs from the bundle.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mhglover

Copy link
Copy Markdown
Contributor Author

Ready to go — companion to got-feedBack/feedBack#1023. bundle-slopsmith.sh stops bundling the club + arena venue packs (~678 MB); bar stays for offline career. Those two download on demand via the career pack pipeline in #1023 (arena live now; club coming-soon and handled gracefully until venue-club-v1 publishes).

Please merge together with got-feedBack/feedBack#1023 (core-first or simultaneous) — stripping the bundle before core can re-download would leave arena with no media and no way to fetch it.

@byrongamatos
byrongamatos merged commit a2e6acf into got-feedBack:main Jul 22, 2026
5 checks passed
@mhglover
mhglover deleted the feat/venue-packs-opt-in branch July 22, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants