Skip to content

fix: bundle all Python deps (PYTHONNOUSERSITE) + no blocking plugin install in packaged builds #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mogul wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: bundle all Python deps (PYTHONNOUSERSITE) + no blocking plugin install in packaged builds #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions scripts/build-common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@

set -euo pipefail

# Isolate the embeddable/standalone Python used for bundling from the BUILD
# machine's per-user site-packages. Without this, pip on a dev machine that has
# a system Python installed sees transitive deps as "already satisfied" via the
# user site (~/.local or %APPDATA%\Python) and SKIPS bundling them (e.g.
# typing_extensions, urllib3, certifi). The packaged app then crashes with
# ModuleNotFoundError on clean end-user machines while "working" on the build
# box. CI runners have no user site, so this is a no-op there.
export PYTHONNOUSERSITE=1

# Check if this is being sourced by a platform script
if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
echo "Error: build-common.sh should not be run directly" >&2
Expand Down
10 changes: 10 additions & 0 deletions src/main/python.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,10 @@ export async function startPython(): Promise<void> {
XDG_CACHE_HOME: cacheBase,
TORCH_HOME: process.env.TORCH_HOME || path.join(cacheBase, 'torch'),
HF_HOME: process.env.HF_HOME || path.join(cacheBase, 'huggingface'),
// Never read the end user's per-user site-packages — the bundle ships
// its own deps, and a stray user-site package must not shadow (or mask
// a gap in) them. Mirrors PYTHONNOUSERSITE=1 used at build time.
PYTHONNOUSERSITE: '1',
RESOURCESPATH: app.isPackaged
? process.resourcesPath
: path.join(__dirname, '..', '..', 'resources'),
Expand Down Expand Up @@ -597,6 +601,12 @@ export async function startPython(): Promise<void> {

// Set PYTHONHOME for bundled Python on all platforms
if (app.isPackaged) {
// Packaged builds ship plugins but must NOT block startup doing a
// runtime `pip install` of heavy optional plugin deps (torch/whisperx/
// demucs) — that hangs the backend past the readiness window on first
// launch. The slopsmith plugin loader honours this flag and loads such
// plugins degraded (their optional features stay off until deps exist).
pythonEnv.SLOPSMITH_SKIP_PLUGIN_INSTALL = '1';
if (process.platform === 'win32') {
pythonEnv.PYTHONHOME = path.join(process.resourcesPath, 'python');
} else {
Expand Down
Loading