feat(job): add per-container env_variables override in module config - #172
Open
mabdh wants to merge 2 commits into
Open
feat(job): add per-container env_variables override in module config#172mabdh wants to merge 2 commits into
mabdh wants to merge 2 commits into
Conversation
Dex re-dumps masked placeholder values into a new job's env vars on Create; masking's Restore only recovers a real secret on Update, so Create ships with no real secret. The job module driver config now accepts containers.<name>.env_variables overrides that are overlaid onto the matching container after the existing global env merge, with the module value always winning regardless of whether the client sent a real or masked value. Independent of masking/sensitive_configs. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…mpty DriverFactory unmarshaled into &kd where kd was already *kubeDriver, so json.Unmarshal received a **kubeDriver. A null/empty module Configs reset kd itself to nil (per encoding/json's null-pointer semantics), returning a non-nil module.Driver interface wrapping a nil pointer. The first field dereference in Output (m.TolerationMode) then segfaulted — hit in production when a job resource's kube_cluster dependency forced a live Output call on a kubernetes module whose registration Configs was empty. Unmarshal into a local value instead, so the returned driver is always non-nil even with empty/null config; log a warning in that case. Applied the same fix to flink's DriverFactory, which had the identical pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mabdh
requested review from
FemiNoviaLina,
deepanshgoyal33,
rajuGT,
shruti-gojek,
snorlacs and
sumitaich1998
July 28, 2026 03:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dex re-dumps masked placeholder values into a new job's env vars on Create; masking's Restore only recovers a real secret on Update, so Create ships with no real secret. The job module driver config now accepts containers..env_variables overrides that are overlaid onto the matching container after the existing global env merge, with the module value always winning regardless of whether the client sent a real or masked value. Independent of masking/sensitive_configs.