Expose public test and benchmark results to polling clients#511
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resultdata in owner-only submission details for publictestandbenchmarkrunsRoot cause
Background submissions persist detailed run results, but
GET /user/submissions/{id}filtered those fields out. Polling clients therefore received only pass/score summaries and could not render individual test or benchmark rows.Impact
This is an additive API response change with no database migration. Existing consumers can ignore the optional field. Secret validation details and potentially large profile payloads remain protected.
Validation
uv run --extra dev ruff check . --exclude examples/ --line-length 120uv run --extra dev pytest tests/test_admin_api.py tests/test_background_submission_manager.py -q(67 passed)Companion CLI: gpu-mode/popcorn-cli#74.