Skip to content

Expose public test and benchmark results to polling clients#511

Merged
msaroufim merged 1 commit into
mainfrom
fix/polled-submission-results
Jul 6, 2026
Merged

Expose public test and benchmark results to polling clients#511
msaroufim merged 1 commit into
mainfrom
fix/polled-submission-results

Conversation

@msaroufim

@msaroufim msaroufim commented Jul 6, 2026

Copy link
Copy Markdown
Member

Summary

  • include persisted per-row result data in owner-only submission details for public test and benchmark runs
  • keep secret, leaderboard, and profile result payloads omitted
  • verify accepted background jobs continue after their request task is cancelled

Root cause

Background submissions persist detailed run results, but GET /user/submissions/{id} filtered those fields out. Polling clients therefore received only pass/score summaries and could not render individual test or benchmark rows.

Impact

This is an additive API response change with no database migration. Existing consumers can ignore the optional field. Secret validation details and potentially large profile payloads remain protected.

Validation

  • uv run --extra dev ruff check . --exclude examples/ --line-length 120
  • uv run --extra dev pytest tests/test_admin_api.py tests/test_background_submission_manager.py -q (67 passed)
  • broader non-Docker suite (164 passed, 14 deselected)

Companion CLI: gpu-mode/popcorn-cli#74.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/libkernelbot
  utils.py
Project Total  

This report was generated by python-coverage-comment-action

@msaroufim msaroufim marked this pull request as ready for review July 6, 2026 21:58
@msaroufim msaroufim merged commit 8f0974a into main Jul 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant