Remove Zig state-machine tests/fuzzer/workload/auditor orphaned by state_machine.zig removal - #7
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
… by state_machine.zig removal Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ocam/src/state_machine.zigwas replaced by the OCamlstate_machine.ml, leaving the Zig files that exercised it orphaned and uncompilable (they all@importthe deletedstate_machine.zig). This PR deletes them plus the plumbing that referenced only them:ocam/src/state_machine/workload.zig,ocam/src/state_machine/auditor.zig,ocam/src/state_machine_tests.zig,ocam/src/state_machine_fuzz.zig.unit_tests.zig: dropped_ = @import("state_machine.zig" | "state_machine_fuzz.zig" | "state_machine_tests.zig").fuzz_tests.zig: dropped the.state_machinefuzzer entry and its.state_machine => 10_000smoke arm (the arm would otherwise name a non-existent enum tag). The.state_machinelog scope is kept, sincetesting/state_machine.zigstill uses it.scripts/cfo.zig: droppedstate_machinefromFuzzerandweightsso CFO doesn't schedule a fuzzer that no longer exists.tidy.zig: dropped the long-line exemption that matched onlystate_machine_tests.zig.Not touched:
testing/state_machine.zig(the synthetic VSR test state machine, a separate file) and the upstream submodule atpath/to/tigerbeetle, which still has the full reference copies.Owner please confirm:
ocam/OCAML_REWRITE.mddescribes the copied Zig tree as a deliberately kept pinned copy / behavior oracle that is meant to be re-linked to the OCaml module later through a C-ABI adapter. If these specific test/fuzz/workload files should stay as part of that reference, close this PR. The originals are still in thepath/to/tigerbeetlesubmodule and in git history.Verification:
dune build,dune runtest,dune build @benchandopam lintall pass. No OCaml files changed, so@fmtis unaffected. Zig is not installed and this Zig tree doesn't compile either before or after this change, so there is no Zig build to run.Link to Devin session: https://app.devin.ai/sessions/d77673098fd7445ab2d932e7537252a7
Open in Devin Desktop: https://app.devin.ai/desktop/session/d77673098fd7445ab2d932e7537252a7?variant=devin
Requested by: @gpu004