Refresh CLAUDE.md for the 7.4 lint job - #19
Merged
Conversation
The managed family-rules block is already identical to the current template; these are the two hand-written claims around it that this release made stale. Lint guidance said the 8.1 image was the lowest in the matrix so a pass covered everything. It no longer is: 7.4 is the declared floor, some sites run it, and php -l cannot see PHP 8 only functions, which parse on 7.4 and fatal at runtime. The CI section gains the php74-syntax job and why the suite cannot run there. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SrD1CtCf7ERCCtH2k7LzK3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/gku:init --refresh. The managedfamily-rulesblock needed no change — diffed againsttemplates/moodle-plugin.mdand it is byte-identical, 82 lines both sides. Nothing inside themarkers was touched.
What had gone stale is the hand-written guidance around it, both from changes made in this
release:
php:8.1-cliimage was the lowest in the CI matrix, so a passthere covered everything. It no longer is — 7.4 is the declared floor, sites run it, and
php -lcannot see a PHP 8 only function:str_containsand friends parse on 7.4 and fatalat runtime. The instruction is now to lint on both images, and it says why the grep exists.
moodle-plugin-cisteps and the superglobal grep, butnot the
php74-syntaxjob added in Say 7.4 on the PHP badge, and make CI enforce it #17, nor thatmoodle-plugin-cineeds PHP 8 and so thesuite cannot run on 7.4 at all.
Documentation only.
.claude/repo-profile.jsonwas also refreshed — it still claimed there wasno
tests/directory, which stopped being true 103 tests ago — but it is gitignored, so itstays local.
No release update: the tag is unchanged and no artifact is affected.