grpc/load_balancing: Update error reporting in child manager. - #2903
Merged
nathanielford merged 2 commits intoOct 2, 2026
Merged
Conversation
Contributor
Author
|
The CI error is being fixed in #2904. Will re-run and merge after that lands (or is otherwise resolved). (And after review, of course.) |
dfawley
approved these changes
Oct 1, 2026
dfawley
left a comment
dfawley
left a comment
Member
There was a problem hiding this comment.
This looks good (once CI passes after the other fix). Thanks!
nathanielford
enabled auto-merge (squash)
October 2, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When working on cluster manager and weighted target LBs, noticed there was no way to identify which error came from which child. (The errors just get joined together.)
Solution
To avoid erasing the error origins, concatenate the child identifier with it's error before they are all joined together.
Notes