Conversation
|
|
Author
|
Failing CI seems unrelated |
Neol3108
marked this pull request as ready for review
October 4, 2026 20:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Building a client for wasm32-wasip2 with the channel feature fails because Tonic imports tokio::net::UnixStream on every non-Windows target. Tokio only exposes this type on Unix targets. WASI is neither Windows nor Unix, so the import fails even when the client only uses TCP.
Solution
Use cfg(unix) for the Unix socket implementation and cfg(not(unix)) for the existing unsupported-platform fallback. This matches Tokio’s platform guards and keeps Unix socket requests returning an error on platforms that don’t support them.
Adds tests for Unix socket connections and the fallback, plus a WASI client compile check in CI. The 77 library tests, WASI compile check, Clippy, and formatting checks pass locally.