🚀 [Release v4.12.0]

.circleci/config.yml

@@ -100,6 +100,54 @@ jobs:
           path: ~/test-results
       - store_artifacts:
           path: ~/test-results/junit
+      - run:
+          name: "Update tests-passed badge (shields.io gist endpoint)"
+          # Only the primary branch's run should own the badge state - a feature
+          # branch with fewer/broken tests shouldn't flap the README badge.
+          # Requires GIST_TOKEN (a PAT with only the `gist` scope) and GIST_ID
+          # to be set as CircleCI project env vars.
+          when: always
+          command: |
+            if [ "$CIRCLE_BRANCH" != "develop" ]; then
+              echo "Not on develop, skipping badge update."
+              exit 0
+            fi
+            if [ -z "$GIST_TOKEN" ] || [ -z "$GIST_ID" ]; then
+              echo "GIST_TOKEN/GIST_ID not set, skipping badge update."
+              exit 0
+            fi
+
+            total=0
+            failures=0
+            skipped=0
+            for f in ~/test-results/junit/*.xml; do
+              [ -f "$f" ] || continue
+              t=$(grep -o 'tests="[0-9]*"' "$f" | head -1 | grep -o '[0-9]*')
+              fl=$(grep -o 'failures="[0-9]*"' "$f" | head -1 | grep -o '[0-9]*')
+              sk=$(grep -o 'skipped="[0-9]*"' "$f" | head -1 | grep -o '[0-9]*')
+              total=$((total + ${t:-0}))
+              failures=$((failures + ${fl:-0}))
+              skipped=$((skipped + ${sk:-0}))
+            done
+            passed=$((total - failures - skipped))
+
+            if [ "$failures" -gt 0 ]; then
+              message="${passed} passed, ${failures} failed"
+              color="red"
+            else
+              message="${passed} passed"
+              color="brightgreen"
+            fi
+
+            payload=$(printf '{"files":{"tests-badge.json":{"content":"{\\"schemaVersion\\":1,\\"label\\":\\"tests\\",\\"message\\":\\"%s\\",\\"color\\":\\"%s\\"}"}}}' "$message" "$color")
+
+            curl -s -X PATCH \
+              -H "Authorization: token ${GIST_TOKEN}" \
+              -H "Accept: application/vnd.github+json" \
+              "https://api.github.com/gists/${GIST_ID}" \
+              -d "$payload" > /dev/null
+
+            echo "Badge updated: ${message}"
 
   screengrab:
     executor:

README.md

@@ -5,6 +5,7 @@
 ### CircleCI status  
 [![Release](https://img.shields.io/github/v/release/gruntsoftware/android?style=plastic)](https://github.com/gruntsoftware/android/releases)
 [![CircleCI](https://dl.circleci.com/status-badge/img/gh/gruntsoftware/android/tree/main.svg?style=svg)](https://dl.circleci.com/status-badge/redirect/gh/gruntsoftware/android/tree/main)
+[![Tests](https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/grunt-claude-bot/ae4830cb1b5da4611598d20a517fd933/raw/tests-badge.json)](https://dl.circleci.com/status-badge/redirect/gh/gruntsoftware/android/tree/develop)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](LICENSE)
 
 ## Play Store
@@ -42,7 +43,7 @@
 
 ### Prerequisites
 - Android Studio (current stable) with SDK 36 installed, NDK `25.1.8937393`, CMake `3.22.1`
-- `minSdk 29`, `targetSdk 35`
+- `minSdk 29`, `targetSdk 36`
 
 ## Architecture
 
@@ -73,6 +74,33 @@ For the full, up-to-date changelog see [GitHub Releases](https://github.com/grun
 
 ---
 
+### **v4.12.0**  [PR [#270](https://github.com/gruntsoftware/android/pull/270)]
+---
+#### ✨ In-App Review Activated
+Google Play's in-app review prompt is now actually wired up after sitting dormant — `InAppReviewService` is registered in Koin and `showInAppReviewDialogIfNeeded()` is called from five placements: after a successful send, the game hub exit flow, the balance-visibility toggle, and two tutorial pages (#260). A follow-up fix decouples the prompt from the social-share flow so it fires on every game exit, not just when the player taps Twitter/Instagram share (#263).
+
+#### 🐛 Bug Fixes
+- **Native `SIGSEGV` crash in `BRPeerManager`** — several accessors (`BRPeerManagerEstimatedBlockHeight`, `LastBlockHeight`, `LastBlockTimestamp`, `SyncProgress`) dereferenced `lastBlock` without a null check, crashing the process if a checkpoint block was ever missing from the persisted block set. `core`'s `BRPeerManager.c` now guards every access and reports the recovery back to the app via a new `BRPeerManagerSetIntegrityWarningCallback`, surfaced through `BRPeerManager.onIntegrityWarning()` to Crashlytics instead of crashing (#269).
+- **RSA public key parsing in `getEncryptedAgentString`** — the provisioned key is an OpenSSH `ssh-rsa <base64-blob> <comment>` line, not base64-encoded PEM; the old PEM-stripping logic corrupted the payload by merging the `ssh-rsa` prefix and comment into it, failing on every call. Now parses the OpenSSH wire format (RFC 4253) directly (#265).
+- **MoonPay signed-url `ipAddress` race** — the Buy button in `ReceiveDialog` could reach MoonPay's signed-url request before the async ipify lookup resolved, sending an empty `ipAddress`. The lookup now happens fresh inside `fetchMoonpaySignedUrl` itself, awaited right before use (#264).
+
+#### 🎮 Fallinmoji v1.6.2
+"How To Play" screen update and a bento corner-radius fix, plus a bw-gdlib bump to pick it up (#268).
+
+#### 📊 Analytics Cleanup
+Removed excess/duplicate events (`app_launched`, `home_open`, a double-firing `did_skip_top_up`) and stopped logging `did_request_rating`/`user_completed_rating` as Firebase events — the Play Core API gives no guarantee a review request actually shows the dialog, so these overstated what happened. Replaced with local `Timber.d` traces (#266).
+
+#### 🧪 Test Coverage
+Added coverage for `InAppReviewService` (gating + Play Core success/failure branches), `UtilsAgentString`'s new OpenSSH parsing path, MoonPay ip-fetch success/failure, and `BRPeerManager.onIntegrityWarning`'s Crashlytics reporting.
+
+#### 🔧 Chores
+- Bumped `targetSdk` to 36 (#267)
+- Version bumped: **v4.11.0 (202506346) → v4.12.0 (202506350)**
+
+**Full Changelog**: https://github.com/gruntsoftware/android/compare/v4.11.0...v4.12.0
+
+---
+
 ### **v4.11.0**  [PR [#259](https://github.com/gruntsoftware/android/pull/259)]
 ---
 #### 🎮 Fallinmoji v1.6.0 — Ready, Set, GO!

app/build.gradle.kts

@@ -30,9 +30,9 @@ android {
     defaultConfig {
         applicationId = "ltd.grunt.brainwallet"
         minSdk = 29
-        targetSdk = 35
-        versionCode = 202506347
-        versionName = "v4.11.0"
+        targetSdk = 36
+        versionCode = 202506350
+        versionName = "v4.12.0"
         multiDexEnabled = true
         base.archivesName.set("${defaultConfig.versionName}(${defaultConfig.versionCode})")
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"

app/src/main/java/com/brainwallet/BrainwalletApp.kt

@@ -37,7 +37,6 @@ open class BrainwalletApp : Application() {
             FirebaseCrashlytics.getInstance().setCustomKey("build_type", "debug")
             FirebaseCrashlytics.getInstance().setUserId("debug_bw_devices")
         }
-        AnalyticsManager.logCustomEvent(BWConstants._20191105_AL)
 
         if (BuildConfig.DEBUG) Timber.plant(DebugTree())
 

app/src/main/java/com/brainwallet/appreview/InAppReviewService.kt

@@ -2,8 +2,6 @@ package com.brainwallet.appreview
 
 import android.app.Activity
 import android.app.Application
-import com.brainwallet.constants.BWConstants
-import com.brainwallet.tools.manager.AnalyticsManager
 import com.brainwallet.tools.manager.BRSharedPrefs
 import com.google.android.gms.tasks.OnCompleteListener
 import com.google.android.gms.tasks.Task
@@ -26,7 +24,6 @@ class InAppReviewService(
             val request = manager.requestReviewFlow()
             request.addOnCompleteListener(
                 OnCompleteListener { task: Task<ReviewInfo>? ->
-                    AnalyticsManager.logCustomEvent(BWConstants._20241006_DRR)
                     if (task!!.isSuccessful()) {
                         val reviewInfo = task.getResult()
                         val flow = manager.launchReviewFlow(activity, reviewInfo)
@@ -41,7 +38,6 @@ class InAppReviewService(
                                 )
                                 if (task1.isSuccessful()) {
                                     BRSharedPrefs.inAppReviewDone(app)
-                                    AnalyticsManager.logCustomEvent(BWConstants._20241006_UCR)
                                 }
                             }
                         )

app/src/main/java/com/brainwallet/constants/BWConstants.kt

@@ -116,11 +116,11 @@ object BWConstants {
      * API Hosts
      */
     const val BW_API_PROD_HOST: String = "https://api.grunt.ltd"
+    const val IPIFY_API_HOST: String = "https://api.ipify.org?format=text"
 
     const val BLOCKCHAIR_EXPLORER_BASE_URL: String = "https://blockchair.com/litecoin/transaction/"
     const val BLOCKCYPHER_EXPLORER_BASE_URL: String = "https://live.blockcypher.com/ltc/"
 
-    const val _20191105_AL: String = "app_launched"
     const val _20191105_VSC: String = "visit_send_controller"
     const val _20202116_VRC: String = "visit_receive_controller"
     const val _20191105_DSL: String = "did_send_ltc"
@@ -133,11 +133,7 @@ object BWConstants {
     const val _20201118_DTGS: String = "did_tap_get_support"
     const val _20200217_DU: String = "did_unlock"
 
-    const val _20250303_DSTU: String = "did_skip_top_up"
     const val _20250517_WCINFO: String = "wallet_callback_info"
-    const val _20241006_DRR: String = "did_request_rating"
-    const val _20241006_UCR: String = "user_completed_rating"
-    const val _HOME_OPEN: String = "home_open"
 
     /**
      * Analytics keys

app/src/main/java/com/brainwallet/data/repository/LtcRepository.kt

@@ -25,6 +25,8 @@ interface LtcRepository {
 
     suspend fun fetchMoonpaySignedUrl(params: Map<String, String>): String
 
+    suspend fun fetchUserIpAddress(): String
+
     companion object {
         const val PREF_KEY_NETWORK_FEE_PER_KB = "network_fee_per_kb"
         const val PREF_KEY_NETWORK_FEE_PER_KB_CACHED_AT = "${PREF_KEY_NETWORK_FEE_PER_KB}_cached_at"

app/src/main/java/com/brainwallet/data/repository/LtcRepositoryImpl.kt

@@ -4,6 +4,7 @@ import android.content.Context
 import android.content.SharedPreferences
 import androidx.core.net.toUri
 import com.brainwallet.BuildConfig
+import com.brainwallet.constants.BWConstants
 import com.brainwallet.data.model.CurrencyEntity
 import com.brainwallet.data.model.Fee
 import com.brainwallet.data.model.LtcStats
@@ -33,8 +34,11 @@ import kotlinx.coroutines.flow.asSharedFlow
 import kotlinx.coroutines.flow.asStateFlow
 import kotlinx.coroutines.isActive
 import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
+import okhttp3.OkHttpClient
+import okhttp3.Request
 import org.koin.core.annotation.Single
 import timber.log.Timber
 
@@ -47,6 +51,7 @@ class LtcRepositoryImpl(
     private val peerManagerSource: PeerManagerSource,
     private val repositoryScope: CoroutineScope = CoroutineScope(SupervisorJob() + Dispatchers.IO),
     private val sharedPreferences: SharedPreferences,
+    private val okHttpClient: OkHttpClient,
 ) : LtcRepository {
 
 //    private val _rates = MutableStateFlow<List<CurrencyEntity>>(
@@ -170,6 +175,7 @@ class LtcRepositoryImpl(
             "externalTransactionId" to externalTransactionID,
             "currencyCode" to "ltc",
             "themeId" to "main-v1.0.0",
+            "ipAddress" to fetchUserIpAddress(),
         )
         return remoteApiSource.getMoonpaySignedUrl(finalParams)
             .signedUrl.toUri()
@@ -182,4 +188,21 @@ class LtcRepositoryImpl(
             .build()
             .toString()
     }
+
+    override suspend fun fetchUserIpAddress(): String = withContext(Dispatchers.IO) {
+        runCatching {
+            val request = Request.Builder()
+                .url(BWConstants.IPIFY_API_HOST)
+                .build()
+            okHttpClient.newCall(request).execute().use { response ->
+                if (response.isSuccessful) {
+                    response.body?.string()?.trim().orEmpty()
+                } else {
+                    ""
+                }
+            }
+        }.onFailure {
+            Timber.e(it, "fetchUserIpAddress failed")
+        }.getOrDefault("")
+    }
 }

app/src/main/java/com/brainwallet/gameinterface/GdxGameView.kt

@@ -77,6 +77,7 @@ fun GdxGameView(
                             this.onExit = { jsonString, bytes ->
                                 removeFragment(fm, tag)
                                 viewModel.onEvent(MainScreenEvent.OnToggleGameHub)
+                                gameHubViewModel.onEvent(GameHubEvent.OnGameFinished)
                                 handleGameExit(jsonString, bytes, gameHubViewModel)
                                 currentOnExit(jsonString, bytes)
                             }

app/src/main/java/com/brainwallet/presenter/activities/BreadActivity.java

@@ -38,15 +38,13 @@
 import com.brainwallet.presenter.customviews.BRNotificationBar;
 import com.brainwallet.presenter.history.HistoryFragment;
 import com.brainwallet.tools.animation.TextSizeTransition;
-import com.brainwallet.tools.manager.AnalyticsManager;
 import com.brainwallet.tools.manager.BRSharedPrefs;
 import com.brainwallet.tools.manager.InternetManager;
 import com.brainwallet.tools.manager.sync.SyncManager;
 import com.brainwallet.tools.security.BitcoinUrlHandler;
 import com.brainwallet.tools.security.PostAuth;
 import com.brainwallet.tools.sqlite.TransactionDataSource;
 import com.brainwallet.tools.threads.BRExecutor;
-import com.brainwallet.constants.BWConstants;
 import com.brainwallet.tools.util.BRCurrency;
 import com.brainwallet.tools.util.BRExchange;
 import com.brainwallet.tools.util.ExtensionKt;
@@ -98,7 +96,6 @@ public static BreadActivity getApp() {
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         setContentView(R.layout.activity_bread);
-        AnalyticsManager.logCustomEvent(BWConstants._HOME_OPEN);
         app = this;
         getWindowManager().getDefaultDisplay().getSize(screenParametersPoint);
 

app/src/main/java/com/brainwallet/tools/util/Utils.java

@@ -21,7 +21,9 @@
 import java.security.NoSuchAlgorithmException;
 import java.security.PublicKey;
 import java.security.spec.InvalidKeySpecException;
-import java.security.spec.X509EncodedKeySpec;
+import java.security.spec.RSAPublicKeySpec;
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
 import java.util.Base64;
 
 import javax.crypto.BadPaddingException;
@@ -198,24 +200,12 @@ public static String getEncryptedAgentString(Context app) {
 
         try {
 
-            // Convert base64 public key string to PublicKey object
-            byte[] keyBytes;
+            // Convert the base64-encoded OpenSSH "ssh-rsa <base64-blob> <comment>" public key
+            // string into an RSAPublicKeySpec
+            RSAPublicKeySpec keySpec;
             try {
                 String pubkey = Utils.fetchServiceItem(app, ServiceItems.AGENTPUBKEY).toString();
-                keyBytes = Base64.getDecoder().decode(pubkey);
-
-                // Decode the base64 to get the PEM string
-                byte[] pemBytes = Base64.getDecoder().decode(pubkey);
-                String pemString = new String(pemBytes, "UTF-8");
-
-                // Extract just the key data (remove PEM headers and whitespace)
-                String keyData = pemString
-                        .replace("-----BEGIN PUBLIC KEY-----", "")
-                        .replace("-----END PUBLIC KEY-----", "")
-                        .replaceAll("\\s+", "");
-
-                // Decode the clean base64 key data
-                keyBytes = Base64.getDecoder().decode(keyData);
+                keySpec = parseOpenSshRsaPublicKey(pubkey);
             } catch (IllegalArgumentException e) {
                 Timber.d("Invalid base64 public key format: %s", e.toString());
                 return "ERROR-CANNOT-KEYBYTES-DO-CONVERSION";
@@ -232,7 +222,7 @@ public static String getEncryptedAgentString(Context app) {
             // Generate PublicKey object
             PublicKey publicKey;
             try {
-                publicKey = keyFactory.generatePublic(new X509EncodedKeySpec(keyBytes));
+                publicKey = keyFactory.generatePublic(keySpec);
             } catch (InvalidKeySpecException e) {
                 Timber.d("Invalid public key specification: %s", e.toString());
                 return "ERROR-CANNOT-INVALID-PUBLIC-KEY-SPEC";
@@ -275,6 +265,42 @@ public static String getEncryptedAgentString(Context app) {
         }
     }
 
+    // Parses a base64-encoded OpenSSH "ssh-rsa <base64-blob> <comment>" public key line
+    // (as provisioned in service-data.json's agent-base64-pubkey) into an RSAPublicKeySpec.
+    // Package-private so it can be unit-tested directly without needing a Context.
+    static RSAPublicKeySpec parseOpenSshRsaPublicKey(String base64EncodedOpenSshLine) {
+        String opensshLine = new String(Base64.getDecoder().decode(base64EncodedOpenSshLine), StandardCharsets.UTF_8);
+
+        // OpenSSH format: "ssh-rsa <base64-encoded-key-blob> [comment]"
+        String[] parts = opensshLine.trim().split("\\s+");
+        if (parts.length < 2) {
+            throw new IllegalArgumentException("Unexpected OpenSSH public key format");
+        }
+        byte[] keyBlob = Base64.getDecoder().decode(parts[1]);
+        return parseSshRsaPublicKeyBlob(keyBlob);
+    }
+
+    // Parses an RFC 4253 "ssh-rsa" wire-format key blob (as found in an OpenSSH
+    // public key line's second field) into the modulus/exponent RSA needs.
+    static RSAPublicKeySpec parseSshRsaPublicKeyBlob(byte[] keyBlob) {
+        ByteBuffer buffer = ByteBuffer.wrap(keyBlob);
+        String keyType = new String(readSshField(buffer), StandardCharsets.UTF_8);
+        if (!"ssh-rsa".equals(keyType)) {
+            throw new IllegalArgumentException("Unsupported SSH key type: " + keyType);
+        }
+        BigInteger exponent = new BigInteger(readSshField(buffer));
+        BigInteger modulus = new BigInteger(readSshField(buffer));
+        return new RSAPublicKeySpec(modulus, exponent);
+    }
+
+    // Each SSH wire-format field is a 4-byte big-endian length followed by that many bytes.
+    private static byte[] readSshField(ByteBuffer buffer) {
+        int length = buffer.getInt();
+        byte[] data = new byte[length];
+        buffer.get(data);
+        return data;
+    }
+
     public static String reverseHex(String hex) {
         if (hex == null) return null;
         StringBuilder result = new StringBuilder();

app/src/main/java/com/brainwallet/ui/bentosections/balancebento/BalanceBentoScreen.kt

@@ -67,6 +67,7 @@ import kotlinx.coroutines.delay
 import kotlinx.coroutines.launch
 import org.koin.compose.koinInject
 import org.koin.compose.viewmodel.koinViewModel
+import timber.log.Timber
 import java.math.BigDecimal
 
 @Composable
@@ -194,6 +195,7 @@ fun BalanceBentoScreen(
                             coroutineScope.launch {
                                 delay(800L)
                                 inAppReviewService.showInAppReviewDialogIfNeeded()
+                                Timber.d("did_request_rating")
                             }
                         }
                     }
@@ -274,6 +276,7 @@ fun BalanceBentoScreen(
                                 coroutineScope.launch {
                                     delay(800L)
                                     inAppReviewService.showInAppReviewDialogIfNeeded()
+                                    Timber.d("did_request_rating")
                                 }
                             }
                         }